1. 18 Mar, 2021 1 commit
  2. 23 Feb, 2021 1 commit
    • Michael Pyne's avatar
      clazy: Fix most remaining warnings. · 288c69eb
      Michael Pyne authored
      I'm not going to worry about non-POD statics in an application, and I
      can't fix the Q_PROPERTY warnings in Phonon. Other than that, all
      default clazy warnings should be gone now.
      Of note is the tagtransactionmanager.cpp setFile call, which is not just
      a warning but an actual bug (good job clazy!).
  3. 24 Feb, 2020 1 commit
  4. 29 Jan, 2020 1 commit
  5. 15 Jan, 2020 1 commit
  6. 13 Jan, 2020 1 commit
  7. 20 Sep, 2019 1 commit
  8. 23 Jun, 2019 1 commit
    • Michael Pyne's avatar
      Fix drag-and-drop of playlist items onto a playlist icon. · 55a6bd71
      Michael Pyne authored
      This allows you to drag music tracks onto a different playlist, by
      dropping the selected tracks onto the name of a different playlist.
      There still seem to be other bugs (Dragging items onto play queue
      doesn't enable play queue automatically; some playlists aren't properly
      saved for some reason). But those will have to be fixed in other
  9. 22 Dec, 2018 2 commits
    • Michael Pyne's avatar
      Port sort function for list of playlists to KF5. · 468a5169
      Michael Pyne authored
      Now that sorting is enabled, it turned out that the sort really was
      broken for everybody (sorry!). The old Qt 3 and 4 "sort by subclassing
      the list item" feature wasn't actually ported into the Qt 5
      compatibilility list view. So although we were defining the compare
      function, nothing was actually using it.
      Things seemed to work fine on my local system but I suspect that's
      because I had playlists from KDE 4 times that I copied over which would
      have already sorted the special playlists to the beginning.
      Since the old method doesn't work I've just added a hidden sort key
      column for now. The "proper solution" is probably to use a
      QSortFilterProxyModel but that will be some time away.
      CHANGELOG:Restore proper sorting of the list of playlists.
    • Michael Pyne's avatar
      Force sorting on so that special playlist sort to top. · dc3124e4
      Michael Pyne authored
      That is, so that special playlists hopefully sort to the top. Although
      the sorting of special playlists (Collection List, Play Queue, etc.) has
      worked for me since the port to KF5, I have a good report that it
      doesn't for others.
      The code itself appears correct but reviewing the Qt documentation
      indicates that QTreeWidget (which is one of the base classes for the
      list of playlists) doesn't sort by default.
      If QTreeWidget doesn't sort, then the comparison function might not be
      getting called at all, which would make it accident that it seems to
      work for me.
  10. 20 Dec, 2018 1 commit
  11. 19 Dec, 2018 1 commit
    • Michael Pyne's avatar
      Use a thread pool for the threaded music loader. · eb4a4d15
      Michael Pyne authored
      Large music libraries can cause dozens/hundreds or even more of threads
      to be created at once. But all we really need is to do the loading off
      of the GUI thread, and the I/O will be the bottleneck no matter how many
      threads we use. So use Qt Concurrent to manage a threadpool instead,
      which also simplifies the code somewhat.
      I also fixed the broken global status updating when using threaded
      loader while refactoring to support this.
  12. 11 Nov, 2018 1 commit
  13. 19 Oct, 2018 2 commits
  14. 10 Feb, 2018 1 commit
  15. 02 Oct, 2017 1 commit
  16. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
  17. 29 Sep, 2017 1 commit
  18. 28 Sep, 2017 1 commit
  19. 26 Aug, 2017 7 commits
  20. 25 Aug, 2017 1 commit
  21. 09 Aug, 2017 1 commit
  22. 27 Jul, 2017 2 commits
  23. 26 Jul, 2017 2 commits
  24. 16 Feb, 2014 1 commit
  25. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
  26. 26 Jun, 2013 1 commit
    • Michael Pyne's avatar
      startup: Async-ify cached item loading on startup, add timers. · bf4df116
      Michael Pyne authored
      In an attempt to get rid of processEvents() (related to several existing
      crash bugs) I am trying to port the startup code towards more
      async-friendly schemes.
      There's no threading but we at least get back to the event loop much
      more frequently while loading files.
      Additionally I have added debug output with instrumentation to show how
      long it takes to advance through each step of the startup (I think this
      might be the first time anyone has understood JuK startup sequence in
      This leaves some essentially dead code with Cache (which no longer
      acts as a container), which I will try to cleanup in later commits.
  27. 17 Jun, 2013 1 commit
    • Michael Pyne's avatar
      Fix GUI flaws on startup. · 74124a0d
      Michael Pyne authored
      Kind of embarassing it took so long to track down why multiple
      seemingly-random PlaylistBox::Items were selected.
  28. 31 Jul, 2011 1 commit
  29. 15 May, 2011 1 commit
  30. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Make the history playlist work again. · faf5e09f
      Michael Pyne authored
      In the great PlayerManager de-singletonizing of KDE 4.1 I managed to not port over the
      Qt signal for the playlist splitter that was emitted on track change, which meant the
      history playlist wouldn't receive it. I've reattached the signal to the history playlist
      which means it works[1] again.
      [1] It's still as broken as it was in KDE 4.0, which means that the "Date" column doesn't
      show up, and all the other columns are shifted over by one to compensate.
      BUG: 168998
      FIXED-IN: 4.5
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136884