Commit a930be48 authored by Albert Astals Cid's avatar Albert Astals Cid
Browse files

Fix crash on exit while uninstalling a theme

We need to make the thememanager return a reference to its list of
themes, this way, takeAt in ThemeModel::removeRows actually removes
the theme from the thememanager too and thus this way there's no attempt
at double delete on shutdown

BUGS: 413278
parent 963ab3e4
...@@ -203,7 +203,7 @@ K3b::ThemeManager::~ThemeManager() ...@@ -203,7 +203,7 @@ K3b::ThemeManager::~ThemeManager()
} }
QList<K3b::Theme*> K3b::ThemeManager::themes() const QList<K3b::Theme*>& K3b::ThemeManager::themes() const
{ {
return d->themes; return d->themes;
} }
......
...@@ -116,7 +116,7 @@ namespace K3b { ...@@ -116,7 +116,7 @@ namespace K3b {
explicit ThemeManager( QObject* parent = 0 ); explicit ThemeManager( QObject* parent = 0 );
~ThemeManager() override; ~ThemeManager() override;
QList<Theme*> themes() const; QList<Theme*>& themes() const;
/** /**
* This is never null. If no theme could be found an empty dummy theme * This is never null. If no theme could be found an empty dummy theme
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment