Commit 01ca6009 authored by Julius Künzel's avatar Julius Künzel
Browse files

[Render Presets] Fix wrongly reversed quality with custom presets

Related to #1393
parent 854c1aef
Pipeline #180059 passed with stage
in 7 minutes and 1 second
...@@ -275,14 +275,14 @@ QStringList RenderPresetModel::audioQualities() const ...@@ -275,14 +275,14 @@ QStringList RenderPresetModel::audioQualities() const
return m_aQualities.split(QLatin1Char(','), Qt::SkipEmptyParts); return m_aQualities.split(QLatin1Char(','), Qt::SkipEmptyParts);
#endif #endif
} else { } else {
//int aq = ui->audioQualitySpinner->value(); // ATTENTION: historically qualities are sorted from best to worse for some reason
QString acodec = getParam(QStringLiteral("acodec")).toLower(); QString acodec = getParam(QStringLiteral("acodec")).toLower();
if (acodec == "libmp3lame") { if (acodec == "libmp3lame") {
return {"9", "0"}; return {"0", "9"};
} else if (acodec == "libvorbis" || acodec == "vorbis") { } else if (acodec == "libvorbis" || acodec == "vorbis") {
return {"0", "10"}; return {"10", "0"};
} else { } else {
return {"0", "500"}; return {"500", "0"};
} }
} }
} }
...@@ -315,15 +315,16 @@ QStringList RenderPresetModel::videoQualities() const ...@@ -315,15 +315,16 @@ QStringList RenderPresetModel::videoQualities() const
return m_vQualities.split(QLatin1Char(','), Qt::SkipEmptyParts); return m_vQualities.split(QLatin1Char(','), Qt::SkipEmptyParts);
#endif #endif
} else { } else {
// ATTENTION: historically qualities are sorted from best to worse for some reason
QString vcodec = getParam(QStringLiteral("vcodec")).toLower(); QString vcodec = getParam(QStringLiteral("vcodec")).toLower();
if (vcodec == "libx265" || vcodec.contains("nvenc") || vcodec.endsWith("_amf") || vcodec.startsWith("libx264") || vcodec.endsWith("_vaapi") || vcodec.endsWith("_qsv")) { if (vcodec == "libx265" || vcodec.contains("nvenc") || vcodec.endsWith("_amf") || vcodec.startsWith("libx264") || vcodec.endsWith("_vaapi") || vcodec.endsWith("_qsv")) {
return {"51", "0"}; return {"0", "51"};
} else if (vcodec.startsWith("libvpx") || vcodec.startsWith("libaom-")) { } else if (vcodec.startsWith("libvpx") || vcodec.startsWith("libaom-")) {
return {"63", "0"}; return {"0", "63"};
} else if (vcodec.startsWith("libwebp")) { } else if (vcodec.startsWith("libwebp")) {
return {"0", "100"}; return {"100", "0"};
} else { } else {
return {"31", "1"}; return {"1", "31"};
} }
} }
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment