Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Multimedia
Kdenlive
Commits
01ca6009
Commit
01ca6009
authored
May 23, 2022
by
Julius Künzel
💬
Browse files
[Render Presets] Fix wrongly reversed quality with custom presets
Related to
#1393
parent
854c1aef
Pipeline
#180059
passed with stage
in 7 minutes and 1 second
Changes
1
Pipelines
1
Show whitespace changes
Inline
Side-by-side
src/renderpresets/renderpresetmodel.cpp
View file @
01ca6009
...
...
@@ -275,14 +275,14 @@ QStringList RenderPresetModel::audioQualities() const
return
m_aQualities
.
split
(
QLatin1Char
(
','
),
Qt
::
SkipEmptyParts
);
#endif
}
else
{
//
int aq = ui->audioQualitySpinner->value();
//
ATTENTION: historically qualities are sorted from best to worse for some reason
QString
acodec
=
getParam
(
QStringLiteral
(
"acodec"
)).
toLower
();
if
(
acodec
==
"libmp3lame"
)
{
return
{
"
9
"
,
"
0
"
};
return
{
"
0
"
,
"
9
"
};
}
else
if
(
acodec
==
"libvorbis"
||
acodec
==
"vorbis"
)
{
return
{
"0"
,
"
1
0"
};
return
{
"
1
0"
,
"0"
};
}
else
{
return
{
"0"
,
"
50
0"
};
return
{
"
50
0"
,
"0"
};
}
}
}
...
...
@@ -315,15 +315,16 @@ QStringList RenderPresetModel::videoQualities() const
return
m_vQualities
.
split
(
QLatin1Char
(
','
),
Qt
::
SkipEmptyParts
);
#endif
}
else
{
// ATTENTION: historically qualities are sorted from best to worse for some reason
QString
vcodec
=
getParam
(
QStringLiteral
(
"vcodec"
)).
toLower
();
if
(
vcodec
==
"libx265"
||
vcodec
.
contains
(
"nvenc"
)
||
vcodec
.
endsWith
(
"_amf"
)
||
vcodec
.
startsWith
(
"libx264"
)
||
vcodec
.
endsWith
(
"_vaapi"
)
||
vcodec
.
endsWith
(
"_qsv"
))
{
return
{
"
51
"
,
"
0
"
};
return
{
"
0
"
,
"
51
"
};
}
else
if
(
vcodec
.
startsWith
(
"libvpx"
)
||
vcodec
.
startsWith
(
"libaom-"
))
{
return
{
"
63
"
,
"
0
"
};
return
{
"
0
"
,
"
63
"
};
}
else
if
(
vcodec
.
startsWith
(
"libwebp"
))
{
return
{
"0"
,
"
10
0"
};
return
{
"
10
0"
,
"0"
};
}
else
{
return
{
"
3
1"
,
"1"
};
return
{
"1"
,
"
3
1"
};
}
}
}
...
...
Eugen Mohr
@emohr
mentioned in issue
#1439
·
May 23, 2022
mentioned in issue
#1439
mentioned in issue #1439
Toggle commit list
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment