Clear effect xmls by moving frei0r into a seperate folder

data/effects/CMakeLists.txt

@@ -23,86 +23,6 @@ fade_to_black.xml
 fadein.xml
 fadeout.xml
 freeze.xml
-frei0r_alpha0ps.xml
-frei0r_alphagrad.xml
-frei0r_alphaspot.xml
-frei0r_balanc0r.xml
-frei0r_baltan.xml
-frei0r_bezier_curves.xml
-frei0r_bgsubtract0r.xml
-frei0r_bigsh0t_eq_mask.xml
-frei0r_bigsh0t_eq_to_rect.xml
-frei0r_bigsh0t_hemi_to_eq.xml
-frei0r_bigsh0t_rect_to_eq.xml
-frei0r_bigsh0t_stabilize_360.xml
-frei0r_bigsh0t_transform_360.xml
-frei0r_brightness.xml
-frei0r_c0rners.xml
-frei0r_cairogradient.xml
-frei0r_cairoimagegrid.xml
-frei0r_cartoon.xml
-frei0r_cluster.xml
-frei0r_colgate.xml
-frei0r_coloradj_rgb.xml
-frei0r_colordistance.xml
-frei0r_colorize.xml
-frei0r_colortap.xml
-frei0r_contrast0r.xml
-frei0r_curves.xml
-frei0r_d90stairsteppingfix.xml
-frei0r_defish0r.xml
-frei0r_delay0r.xml
-frei0r_delaygrab.xml
-frei0r_distort0r.xml
-frei0r_dither.xml
-frei0r_edgeglow.xml
-frei0r_emboss.xml
-frei0r_equaliz0r.xml
-frei0r_facebl0r.xml
-frei0r_facedetect.xml
-frei0r_flippo.xml
-frei0r_glitch0r.xml
-frei0r_glow.xml
-frei0r_hqdn3d.xml
-frei0r_hueshift0r.xml
-frei0r_iirblur.xml
-frei0r_keyspillm0pup.xml
-frei0r_lenscorrection.xml
-frei0r_letterb0xed.xml
-frei0r_levels.xml
-frei0r_lightgraffiti.xml
-frei0r_luminance.xml
-frei0r_mask0mate.xml
-frei0r_medians.xml
-frei0r_nervous.xml
-frei0r_nosync0r.xml
-frei0r_pixeliz0r.xml
-frei0r_pr0be.xml
-frei0r_pr0file.xml
-frei0r_primaries.xml
-frei0r_rgbnoise.xml
-frei0r_rgbparade.xml
-frei0r_rgbsplit0r.xml
-frei0r_saturat0r.xml
-frei0r_scale0tilt.xml
-frei0r_scanline0r.xml
-frei0r_select0r.xml
-frei0r_sharpness.xml
-frei0r_sigmoidaltransfer.xml
-frei0r_sobel.xml
-frei0r_softglow.xml
-frei0r_sopsat.xml
-frei0r_squareblur.xml
-frei0r_tehroxx0r.xml
-frei0r_three_point_balance.xml
-frei0r_threelay0r.xml
-frei0r_threshold0r.xml
-frei0r_timeout.xml
-frei0r_tint0r.xml
-frei0r_twolay0r.xml
-frei0r_vectorscope.xml
-frei0r_vertigo.xml
-frei0r_vignette.xml
 gain.xml
 gamma.xml
 gpstext.xml
@@ -172,3 +92,4 @@ DESTINATION ${DATA_INSTALL_DIR}${DATA_INSTALL_PREFIX}/effects)
 
 add_subdirectory(update)
 add_subdirectory(avfilter)
+add_subdirectory(frei0r)

data/effects/frei0r/CMakeLists.txt

+INSTALL (FILES 
+
+frei0r_alpha0ps.xml
+frei0r_alphagrad.xml
+frei0r_alphaspot.xml
+frei0r_balanc0r.xml
+frei0r_baltan.xml
+frei0r_bezier_curves.xml
+frei0r_bgsubtract0r.xml
+frei0r_bigsh0t_eq_mask.xml
+frei0r_bigsh0t_eq_to_rect.xml
+frei0r_bigsh0t_hemi_to_eq.xml
+frei0r_bigsh0t_rect_to_eq.xml
+frei0r_bigsh0t_stabilize_360.xml
+frei0r_bigsh0t_transform_360.xml
+frei0r_brightness.xml
+frei0r_c0rners.xml
+frei0r_cairogradient.xml
+frei0r_cairoimagegrid.xml
+frei0r_cartoon.xml
+frei0r_cluster.xml
+frei0r_colgate.xml
+frei0r_coloradj_rgb.xml
+frei0r_colordistance.xml
+frei0r_colorize.xml
+frei0r_colortap.xml
+frei0r_contrast0r.xml
+frei0r_curves.xml
+frei0r_d90stairsteppingfix.xml
+frei0r_defish0r.xml
+frei0r_delay0r.xml
+frei0r_delaygrab.xml
+frei0r_distort0r.xml
+frei0r_dither.xml
+frei0r_edgeglow.xml
+frei0r_emboss.xml
+frei0r_equaliz0r.xml
+frei0r_facebl0r.xml
+frei0r_facedetect.xml
+frei0r_flippo.xml
+frei0r_glitch0r.xml
+frei0r_glow.xml
+frei0r_hqdn3d.xml
+frei0r_hueshift0r.xml
+frei0r_iirblur.xml
+frei0r_keyspillm0pup.xml
+frei0r_lenscorrection.xml
+frei0r_letterb0xed.xml
+frei0r_levels.xml
+frei0r_lightgraffiti.xml
+frei0r_luminance.xml
+frei0r_mask0mate.xml
+frei0r_medians.xml
+frei0r_nervous.xml
+frei0r_nosync0r.xml
+frei0r_pixeliz0r.xml
+frei0r_pr0be.xml
+frei0r_pr0file.xml
+frei0r_primaries.xml
+frei0r_rgbnoise.xml
+frei0r_rgbparade.xml
+frei0r_rgbsplit0r.xml
+frei0r_saturat0r.xml
+frei0r_scale0tilt.xml
+frei0r_scanline0r.xml
+frei0r_select0r.xml
+frei0r_sharpness.xml
+frei0r_sigmoidaltransfer.xml
+frei0r_sobel.xml
+frei0r_softglow.xml
+frei0r_sopsat.xml
+frei0r_squareblur.xml
+frei0r_tehroxx0r.xml
+frei0r_three_point_balance.xml
+frei0r_threelay0r.xml
+frei0r_threshold0r.xml
+frei0r_timeout.xml
+frei0r_tint0r.xml
+frei0r_twolay0r.xml
+frei0r_vectorscope.xml
+frei0r_vertigo.xml
+frei0r_vignette.xml
+DESTINATION ${DATA_INSTALL_DIR}${DATA_INSTALL_PREFIX}/effects)

[Antonio Rojas]

Is it intentional that they're installed to a different dir?

[Julius Künzel]

@arojas Thanks for heads up! What do mean by different? Different than what? You mean effects instead of effects/frei0r? If so yes this is intended. The goal was to make the folder structure more clean in the source code, but to make Kdenlive find all the effect files we have to install all files to the effects folder in ${DATA_INSTALL_DIR}${DATA_INSTALL_PREFIX} and not to subfolders…

[Antonio Rojas]

No, I mean ${DATA_INSTALL_PREFIX}/effects vs ${DATA_INSTALL_PREFIX}/kdenlive/effects

[Julius Künzel]

@arojas If ${DATA_INSTALL_DIR}/kdenlive/effects is still used somewhere this is wrong.

Since on macOS we need to install to ${DATA_INSTALL_DIR}/effects (without kdenlive) I introduced DATA_INSTALL_PREFIX (which is kdenlive on all OSs exepct macOS) on commit 99781d53. So now it should be ${DATA_INSTALL_DIR}${DATA_INSTALL_PREFIX}/effects everywhere…

[Antonio Rojas]

OK, so the thing is that this was cherry-picked to 21.08 but 99781d53 wasn't. So these are installed to the wrong path in 21.08, and it affects the pre-release 21.08.2 tarballs. You may want to fix it asap and ping @heikobecker for a respin before the official release this Thursday.

[Julius Künzel]

Oh yes! Working on a fix right now!