Commit a59e74a7 authored by Eric Jiang's avatar Eric Jiang Committed by Jean-Baptiste Mardelle
Browse files

test_utils: pass by const reference (cppcheck)

parent fc8be2bf
Pipeline #194353 passed with stage
in 6 minutes and 17 seconds
......@@ -69,7 +69,7 @@ QString createAVProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> b
return binId;
}
QString createTextProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel, QString xmldata, QString clipname, int length)
QString createTextProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel, const QString &xmldata, const QString &clipname, int length)
{
std::shared_ptr<Mlt::Producer> producer =
std::make_shared<Mlt::Producer>(prof, "kdenlivetitle");
......@@ -93,7 +93,7 @@ QString createTextProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel>
return binId;
}
std::unique_ptr<QDomElement> getProperty(const QDomElement &doc, QString name) {
std::unique_ptr<QDomElement> getProperty(const QDomElement &doc, const QString &name) {
QDomNodeList list = doc.elementsByTagName("property");
for (int i = 0; i < list.count(); i++) {
QDomElement e = list.at(i).toElement();
......
......@@ -87,8 +87,8 @@ QString createProducer(Mlt::Profile &prof, std::string color, std::shared_ptr<Pr
QString createProducerWithSound(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel, int length = 10);
QString createTextProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel, QString xmldata, QString clipname, int length = 10);
QString createTextProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel, const QString &xmldata, const QString &clipname, int length = 10);
QString createAVProducer(Mlt::Profile &prof, std::shared_ptr<ProjectItemModel> binModel);
std::unique_ptr<QDomElement> getProperty(const QDomElement& element, QString name);
std::unique_ptr<QDomElement> getProperty(const QDomElement& element, const QString& name);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment