Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Multimedia
Kdenlive
Commits
ac4795e7
Commit
ac4795e7
authored
Sep 17, 2022
by
Julius Künzel
💬
Browse files
Fix crash on bin clip deletion with instance on locked track
BUG: 459260
parent
a5351b85
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/bin/projectclip.cpp
View file @
ac4795e7
...
...
@@ -1967,7 +1967,9 @@ bool ProjectClip::selfSoftDelete(Fun &undo, Fun &redo)
}
if
(
auto
timeline
=
clip
.
second
.
lock
())
{
timeline
->
requestClipUngroup
(
clip
.
first
,
undo
,
redo
);
timeline
->
requestItemDeletion
(
clip
.
first
,
undo
,
redo
,
true
);
if
(
!
timeline
->
requestItemDeletion
(
clip
.
first
,
undo
,
redo
,
true
))
{
return
false
;
}
}
else
{
qDebug
()
<<
"Error while deleting clip: timeline unavailable"
;
Q_ASSERT
(
false
);
...
...
src/bin/projectitemmodel.cpp
View file @
ac4795e7
...
...
@@ -674,7 +674,9 @@ bool ProjectItemModel::requestBinClipDeletion(const std::shared_ptr<AbstractProj
binId
=
ptr
->
clipId
();
}
bool
isSubClip
=
clip
->
itemType
()
==
AbstractProjectItem
::
SubClipItem
;
clip
->
selfSoftDelete
(
undo
,
redo
);
if
(
!
clip
->
selfSoftDelete
(
undo
,
redo
))
{
return
false
;
}
int
id
=
clip
->
getId
();
Fun
operation
=
removeItem_lambda
(
id
);
Fun
reverse
=
addItem_lambda
(
clip
,
parentId
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment