Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Multimedia
Kdenlive
Commits
b0b13930
Commit
b0b13930
authored
May 17, 2022
by
Jean-Baptiste Mardelle
Browse files
Fix possible crash in transcoding dialog if there are no clips to convert
parent
81316715
Pipeline
#177696
passed with stage
in 9 minutes and 18 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
src/bin/bin.cpp
View file @
b0b13930
...
...
@@ -4961,21 +4961,27 @@ void Bin::requestTranscoding(const QString &url, const QString &id, int type, bo
m_transcodingDialog
=
new
TranscodeSeek
(
this
);
connect
(
m_transcodingDialog
,
&
QDialog
::
accepted
,
this
,
[
&
,
checkProfile
]
()
{
QMap
<
QString
,
QStringList
>
ids
=
m_transcodingDialog
->
ids
();
QString
firstId
=
ids
.
firstKey
();
QMapIterator
<
QString
,
QStringList
>
i
(
ids
);
while
(
i
.
hasNext
())
{
i
.
next
();
std
::
shared_ptr
<
ProjectClip
>
clip
=
m_itemModel
->
getClipByBinID
(
i
.
key
());
TranscodeTask
::
start
({
ObjectType
::
BinClip
,
i
.
key
().
toInt
()},
i
.
value
().
first
(),
m_transcodingDialog
->
preParams
(),
m_transcodingDialog
->
params
(
i
.
value
().
at
(
1
).
toInt
()),
-
1
,
-
1
,
true
,
clip
.
get
(),
false
,
i
.
key
()
==
firstId
?
checkProfile
:
false
);
if
(
!
ids
.
isEmpty
())
{
QString
firstId
=
ids
.
firstKey
();
QMapIterator
<
QString
,
QStringList
>
i
(
ids
);
while
(
i
.
hasNext
())
{
i
.
next
();
std
::
shared_ptr
<
ProjectClip
>
clip
=
m_itemModel
->
getClipByBinID
(
i
.
key
());
TranscodeTask
::
start
({
ObjectType
::
BinClip
,
i
.
key
().
toInt
()},
i
.
value
().
first
(),
m_transcodingDialog
->
preParams
(),
m_transcodingDialog
->
params
(
i
.
value
().
at
(
1
).
toInt
()),
-
1
,
-
1
,
true
,
clip
.
get
(),
false
,
i
.
key
()
==
firstId
?
checkProfile
:
false
);
}
}
m_transcodingDialog
->
deleteLater
();
m_transcodingDialog
=
nullptr
;
});
connect
(
m_transcodingDialog
,
&
QDialog
::
rejected
,
this
,
[
&
,
checkProfile
]
()
{
QString
firstId
=
m_transcodingDialog
->
ids
().
firstKey
();
QMap
<
QString
,
QStringList
>
ids
=
m_transcodingDialog
->
ids
();
QString
firstId
;
if
(
!
ids
.
isEmpty
())
{
firstId
=
ids
.
firstKey
();
}
m_transcodingDialog
->
deleteLater
();
m_transcodingDialog
=
nullptr
;
if
(
checkProfile
)
{
if
(
checkProfile
&&
!
firstId
.
isEmpty
()
)
{
pCore
->
bin
()
->
slotCheckProfile
(
firstId
);
}
});
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment