Remember searchbar visibility, related to #350

src/assets/assetlist/view/assetlistwidget.cpp

@@ -108,3 +108,17 @@ void AssetListWidget::activate(const QModelIndex &ix)
     const QString assetId = m_model->data(m_proxyModel->mapToSource(ix), AssetTreeModel::IdRole).toString();
     emit activateAsset(getMimeData(assetId));
 }
+
+bool AssetListWidget::showSearchBar(bool isEffectList) const
+{
+    return isEffectList ? KdenliveSettings::showEffectSearchBar() : KdenliveSettings::showCompoSearchBar();
+}
+
+void AssetListWidget::setShowSearchBar(bool isEffectList, bool show)
+{
+    if (isEffectList) {
+        KdenliveSettings::setShowEffectSearchBar(show);
+    } else {
+        KdenliveSettings::setShowCompoSearchBar(show);
+    }
+}

src/assets/assetlist/view/assetlistwidget.hpp

@@ -68,6 +68,10 @@ public:
 
     /* @brief Rebuild the view by resetting the source. Is there a better way? */
     void reset();
+    
+    /* @brief Show search bar on opening */
+    bool showSearchBar(bool isEffectList) const;
+    void setShowSearchBar(bool isEffectList, bool show);
 
 protected:
     void setup();

src/assets/assetlist/view/qml/assetList.qml

@@ -63,8 +63,10 @@ Rectangle {
                 id: searchList
                 iconName: "edit-find"
                 checkable: true
+                checked: assetlist.showSearchBar(isEffectList)
                 tooltip: isEffectList ? i18n("Find effect") : i18n("Find composition")
                 onCheckedChanged: {
+                    assetlist.setShowSearchBar(isEffectList, searchList.checked)
                     searchInput.visible = searchList.checked
                     searchInput.focus = searchList.checked
                     if (!searchList.checked) {
@@ -169,7 +171,7 @@ Rectangle {
                 opacity: 0
                 MouseArea {
                     anchors.fill: parent
-                    onClicked: { searchInput.text = ''; searchInput.focus = true; searchList.checked = false; }
+                    onClicked: { searchInput.text = ''; searchInput.focus = true; /*searchList.checked = false;*/ }
                 }
             }
             states: State {
@@ -217,7 +219,7 @@ Rectangle {
             Keys.onReturnPressed: {
                 if (sel.hasSelection) {
                     assetlist.activate(sel.currentIndex)
-                    searchList.checked = false
+                    treeView.focus = true
                 }
             }
         }

src/effects/effectlist/view/effectlistwidget.hpp

@@ -84,6 +84,8 @@ public:
     Q_INVOKABLE void setFilterType(const QString &type) { q->setFilterType(type); }
     Q_INVOKABLE void setFilterName(const QString &pattern) { q->setFilterName(pattern); }
     Q_INVOKABLE QString getMimeType(const QString &assetId) const { return q->getMimeType(assetId); }
+    Q_INVOKABLE bool showSearchBar(bool isEffectList) const { return q->showSearchBar(isEffectList); }
+    Q_INVOKABLE void setShowSearchBar(bool isEffectList, bool show) { q->setShowSearchBar(isEffectList, show); }
     bool showDescription() const { return KdenliveSettings::showeffectinfo(); }
 
     void setShowDescription(bool show)

src/kdenlivesettings.kcfg

@@ -123,6 +123,17 @@
       <label>Default OpenGL backend.</label>
       <default>0</default>
     </entry>
+    
+    <entry name="showEffectSearchBar" type="Bool">
+      <label>Show effect search bar by default.</label>
+      <default>true</default>
+    </entry>
+    
+    <entry name="showCompoSearchBar" type="Bool">
+      <label>Show composition search bar by default.</label>
+      <default>true</default>
+    </entry>
+    
 
   </group>
 

src/transitions/transitionlist/view/transitionlistwidget.hpp

@@ -78,6 +78,8 @@ public:
 
     Q_INVOKABLE void setFilterName(const QString &pattern) { q->setFilterName(pattern); }
     Q_INVOKABLE QString getMimeType(const QString &assetId) const { return q->getMimeType(assetId); }
+    Q_INVOKABLE bool showSearchBar(bool isEffectList) const { return q->showSearchBar(isEffectList); }
+    Q_INVOKABLE void setShowSearchBar(bool isEffectList, bool show) { q->setShowSearchBar(isEffectList, show); }
     Q_INVOKABLE void downloadNewLumas() { q->downloadNewLumas(); }
     bool showDescription() const { return KdenliveSettings::showeffectinfo(); }