Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Multimedia
Kdenlive
Commits
e7638efd
Commit
e7638efd
authored
Mar 11, 2020
by
Jean-Baptiste Mardelle
Browse files
Fix audio thumbs sometimes not appearing on clip quick insert
CCBUG: 417110
parent
8cce530d
Pipeline
#16307
failed with stage
in 2 minutes and 23 seconds
Changes
4
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
src/bin/projectclip.cpp
View file @
e7638efd
...
...
@@ -201,6 +201,7 @@ void ProjectClip::updateAudioThumbnail(const QVector<uint8_t> audioLevels)
{
audioFrameCache
=
audioLevels
;
m_audioThumbCreated
=
true
;
updateTimelineClips
({
TimelineModel
::
ReloadThumbRole
});
}
bool
ProjectClip
::
audioThumbCreated
()
const
...
...
src/timeline2/view/qml/Clip.qml
View file @
e7638efd
...
...
@@ -136,7 +136,7 @@ Rectangle {
width
=
clipDuration
*
timeScale
;
if
(
parentTrack
&&
parentTrack
.
isAudio
&&
thumbsLoader
.
item
)
{
// Duration changed, we may need a different number of repeaters
thumbsLoader
.
item
.
reload
()
thumbsLoader
.
item
.
reload
(
1
)
}
}
...
...
@@ -163,7 +163,7 @@ Rectangle {
onForceReloadThumbChanged
:
{
// TODO: find a way to force reload of clip thumbs
if
(
thumbsLoader
.
item
)
{
thumbsLoader
.
item
.
reload
()
thumbsLoader
.
item
.
reload
(
0
)
}
}
...
...
src/timeline2/view/qml/ClipAudioThumbs.qml
View file @
e7638efd
...
...
@@ -16,7 +16,10 @@ Row {
onTriggered
:
processReload
()
}
function
reload
()
{
function
reload
(
reset
)
{
if
(
reset
==
0
)
{
waveformRepeater
.
model
=
0
}
waveTimer
.
start
()
}
onMaxWidthChanged
:
{
...
...
src/timeline2/view/qml/ClipThumbs.qml
View file @
e7638efd
...
...
@@ -13,8 +13,8 @@ Row {
property
int
thumbWidth
:
container
.
height
*
root
.
dar
property
bool
enableCache
:
clipRoot
.
itemType
==
ProducerType
.
Video
||
clipRoot
.
itemType
==
ProducerType
.
AV
function
reload
()
{
console
.
log
(
'
+++++
\n\n
triggered ML thumb reload
\n\n
++++++++++++++
'
)
function
reload
(
reset
)
{
//
console.log('+++++\n\ntriggered ML thumb reload\n\n++++++++++++++')
clipRoot
.
baseThumbPath
=
clipRoot
.
variableThumbs
?
''
:
'
image://thumbnail/
'
+
clipRoot
.
binId
+
'
/
'
+
Math
.
random
()
+
'
/#
'
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment