Fix compile warnings

src/assets/view/widgets/buttonparamwidget.cpp

@@ -56,7 +56,7 @@ ButtonParamWidget::ButtonParamWidget(std::shared_ptr<AssetParameterModel> model,
 #endif
 
     QString conditionalInfo;
-    for (const QVariant jobElement : filterData) {
+    for (const QVariant &jobElement : filterData) {
         QStringList d = jobElement.toStringList();
         if (d.size() == 2) {
             if (d.at(0) == QLatin1String("conditionalinfo")) {
@@ -118,7 +118,7 @@ ButtonParamWidget::ButtonParamWidget(std::shared_ptr<AssetParameterModel> model,
         }
         std::unordered_map<QString, QVariant> fParams;
         std::unordered_map<QString, QString> fData;
-        for (const QVariant jobElement : filterData) {
+        for (const QVariant &jobElement : filterData) {
             QStringList d = jobElement.toStringList();
             if (d.size() == 2)
             fData.insert({d.at(0), d.at(1)});

src/audiomixer/mixermanager.cpp

@@ -37,14 +37,6 @@
 
 const double log_factor = 1.0 / log10(1.0 / 127);
 
-static inline double levelToDB(double level)
-{
-    if (level <= 0) {
-        return -100;
-    }
-    return 100 * (1.0 - log10(level) * log_factor);
-}
-
 MixerManager::MixerManager(QWidget *parent)
     : QWidget(parent)
     , m_masterMixer(nullptr)

src/mainwindow.cpp

@@ -1378,7 +1378,7 @@ void MainWindow::setupActions()
         overlayAudioInfo->setEnabled(toggled);
     });
 
-#if LIBMLT_VERSION_INT >= MLT_VERSION_PREVIEW_SCALE
+#if LIBMLT_VERSION_INT >= QT_VERSION_CHECK(6,20,0)
     // Monitor resolution scaling
     m_scaleGroup = new QActionGroup(this);
     m_scaleGroup->setExclusive(true);

src/monitor/glwidget.cpp

@@ -1834,7 +1834,7 @@ void GLWidget::setConsumerProperty(const QString &name, const QString &value)
 
 void GLWidget::updateScaling()
 {
-#if LIBMLT_VERSION_INT >= MLT_VERSION_PREVIEW_SCALE
+#if LIBMLT_VERSION_INT >= QT_VERSION_CHECK(6,20,0)
     int previewHeight = pCore->getCurrentFrameSize().height();
     switch (KdenliveSettings::previewScaling()) {
         case 2:

src/titler/titlewidget.cpp

@@ -64,10 +64,12 @@ const int IMAGEITEM = 7;
 const int RECTITEM = 3;
 const int TEXTITEM = 8;
 
+/*
 const int NOEFFECT = 0;
 const int BLUREFFECT = 1;
 const int SHADOWEFFECT = 2;
 const int TYPEWRITEREFFECT = 3;
+*/
 
 void TitleWidget::refreshTemplateBoxContents()
 {

src/utils/thumbnailcache.cpp

@@ -310,7 +310,7 @@ QStringList ThumbnailCache::getAudioKey(const QString &binId, bool *ok)
         }
         QStringList streamsList;
         QStringList streamIndexes = streams.split(QLatin1Char(';'));
-        for (const QString st : streamIndexes) {
+        for (const QString &st : streamIndexes) {
             streamsList << QString("%1_%2.png").arg(binClip->hash()).arg(st);
         }
         return streamsList;