Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Multimedia
Kdenlive
Commits
fe4ffc18
Commit
fe4ffc18
authored
Nov 25, 2022
by
Jean-Baptiste Mardelle
Browse files
Fix possible crash on very fast drag & drop in timeline
parent
5b774add
Pipeline
#274340
passed with stage
in 16 minutes and 49 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
src/timeline2/view/qml/timeline.qml
View file @
fe4ffc18
...
...
@@ -786,9 +786,8 @@ Rectangle {
// If we exit on top, remove clip
controller
.
requestItemDeletion
(
clipBeingDroppedId
,
false
)
clearDropData
()
}
else
if
(
clipBeingDroppedId
>
-
1
)
{
}
else
if
(
clipBeingDroppedId
>
-
1
&&
fakeTrack
>
-
1
)
{
// Clip is dropped
//console.log('Dragging on left side!!!!!!!!!!!!!!!!!!!!!!!!!!!')
var
moveData
=
controller
.
suggestClipMove
(
clipBeingDroppedId
,
fakeTrack
,
0
,
root
.
consumerPosition
,
root
.
snapping
)
fakeFrame
=
moveData
[
0
]
fakeTrack
=
moveData
[
1
]
...
...
@@ -803,7 +802,6 @@ Rectangle {
}
var
track
=
Logic
.
getTrackIndexFromPos
(
drag
.
y
+
scrollView
.
contentY
-
yOffset
)
if
(
track
>=
0
&&
track
<
tracksRepeater
.
count
)
{
//timeline.activeTrack = tracksRepeater.itemAt(track).trackInternalId
var
targetTrack
=
tracksRepeater
.
itemAt
(
track
).
trackInternalId
var
frame
=
Math
.
floor
((
drag
.
x
+
scrollView
.
contentX
)
/
root
.
timeScale
)
if
(
clipBeingDroppedId
>
-
1
)
{
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment