Skip to content

Download online resources thumbnails in parallel

balooii balooii requested to merge balooii/kdenlive:speed_up_thumbnail_loading_of_online_resources into master
  • previously thumbs have been loaded sequentially which wasn't the best experience. This change speeds it up by running these requests in parallel
  • according to docs QNetworkAccessManager executes up to 6 requests in parallel which fits this purpose and shouldn't overload these APIs. Added rate limit handling in case User goes wild
  • don't use temporary files to download the thumbnails before converting to pixmaps. Just do it in memory

Before:

online_resources_thumbnails_sequential

After:

online_resources_thumbnails_parallel

Merge request reports