Commit 782667be authored by Simon Eugster's avatar Simon Eugster

Do not convert decimal separator in time codes

parent f07ea0f6
......@@ -1756,22 +1756,6 @@ auto DocumentValidator::upgradeTo100(const QLocale &documentLocale) -> bool {
}
}
auto producers = m_doc.elementsByTagName(QStringLiteral("producer"));
for (int i = 0; i < producers.count(); i++) {
auto attributes = producers.at(i).attributes();
QList<QDomNode> attributesToConvert;
attributesToConvert << attributes.namedItem("in") << attributes.namedItem("out");
for (QDomNode &attr : attributesToConvert) {
if (!attr.isNull()) {
QString originalValue = attr.nodeValue();
QString newValue = originalValue.replace(decimalPoint, '.');
attr.setNodeValue(newValue);
qDebug() << "Decimal separator: Converted producer attribute " << attr.nodeName() << " from " << originalValue << " to " << newValue;
}
}
}
} else {
qDebug() << "Decimal point is OK";
}
......
......@@ -18,10 +18,6 @@ the Free Software Foundation, either version 3 of the License, or
#include <klocalizedstring.h>
#include <QtConcurrent>
#include "kdenlive_debug.h"
#include <QFile>
#include <QStandardPaths>
#include <framework/mlt_log.h>
#include <lib/localeHandling.h>
#include <mlt++/MltFactory.h>
#include <mlt++/MltRepository.h>
......
......@@ -22,10 +22,18 @@
#include "gentime.h"
/**
Handles the conversion of a GenTime into a nicely formatted string, taking into account things such as drop frame if necessary. Handles multiple formats, such
as HH:MM:SS:FF, HH:MM:SS:F, All Frames, All Seconds, etc.
@author Jason Wood
* Handles the conversion of a GenTime into a nicely formatted string, taking into account things such as drop frame if necessary.
* Handles multiple formats, such as HH:MM:SS:FF, HH:MM:SS:F, All Frames, All Seconds, etc.
*
* For 29.97, 59.94, or 23.976 fps, the drop-frame timecode is used: For this frame rate, frames 0 and 1 are dropped every minute
* but not every 10th to fix time shift; see https://en.wikipedia.org/wiki/SMPTE_timecode for details.
*
* To distinguish between normal and drop-frame timecode, they use a different format.
*
* HH:MM:SS:FF → Normal time code in hour/minute/second/frame format
* HH:MM:SS,FF → Drop-frame time code
*
* @author Jason Wood
*/
class Timecode
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment