Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit bf05f244 authored by Nicolas Carion's avatar Nicolas Carion

clean up a bunch of unused functions

parent d4548ceb
......@@ -3122,15 +3122,6 @@ void Bin::saveZone(const QStringList &info, const QDir &dir)
QVariantList Bin::audioFrameCache(const QString &id)
std::shared_ptr<ProjectClip> clip = getBinClip(id);
if (clip) {
return clip->audioFrameCache;
return QVariantList();
void Bin::setCurrent(std::shared_ptr<AbstractProjectItem> item)
switch (item->itemType()) {
......@@ -287,7 +287,6 @@ public:
QString getCurrentFolder();
/** @brief Save a clip zone as MLT playlist */
void saveZone(const QStringList &info, const QDir &dir);
QVariantList audioFrameCache(const QString &id);
void addWatchFile(const QString &binId, const QString &url);
void removeWatchFile(const QString &binId, const QString &url);
......@@ -2243,7 +2243,6 @@ void MainWindow::slotSwitchVideoThumbs()
void MainWindow::slotSwitchAudioThumbs()
This diff is collapsed.
......@@ -51,19 +51,11 @@ public:
explicit BinController(const QString &profileName = QString());
virtual ~BinController();
/** @brief Returns the service for the Bin's playlist, used to make sure MLT will save it correctly in its XML. */
mlt_service service();
friend class ClipController;
friend class ProjectClip;
/** @brief Add a new clip producer to the project.
This is protected because it should be called only by the ClipController itself upon creation
* @param id The clip's id
* @param producer The MLT producer for this clip
* */
void addClipToBin(const QString &id, const std::shared_ptr<ClipController> &controller, bool fromPlaylist = false);
/** @brief Store a timeline producer in clip list for later re-use
......@@ -78,29 +70,12 @@ public:
/** @brief Clear the bin's playlist */
void destroyBin();
/** @brief Load the Bin's main playlist from an existing tractor, and pass it to the model */
void loadBinPlaylist(Mlt::Tractor *documentTractor, Mlt::Tractor *modelTractor);
/** @brief Initialize the bin's playlist from MLT's data
* @param playlist The MLT playlist containing our bin's clips
void initializeBin(Mlt::Playlist playlist);
/** @brief If our bin's playlist does not exist, create a new one */
void createIfNeeded(Mlt::Profile *profile);
/** @brief Returns true if a clip with that id is in our bin's playlist
* @param id The clip's id as stored in DocClipBase
bool hasClip(const QString &id);
QStringList getClipIds() const;
/** @brief Delete a clip from the bin from its id.
* @param id The clip's id as stored in DocClipBase
* @return true on success, false on error
bool removeBinClip(const QString &id);
/** @brief Get the MLT Producer for a given id.
@param id The clip id as stored in the DocClipBase class */
......@@ -111,9 +86,6 @@ public:
// @param speed If the clip has a speed effect (framebuffer producer), we indicate the speed here
std::shared_ptr<Mlt::Producer> getBinProducer(const QString &id);
/** @brief returns a video only (no audio) version of this producer */
Mlt::Producer *getBinVideoProducer(const QString &id);
/** @brief Returns the clip data as rendered by MLT's XML consumer, used to duplicate a clip
* @param producer The clip's original producer
......@@ -125,7 +97,6 @@ public:
QString xmlFromId(const QString &id);
int clipCount() const;
Mlt::Producer *cloneProducer(Mlt::Producer &original);
std::shared_ptr<ClipController> getController(const QString &id);
const QList<std::shared_ptr<ClipController>> getControllerList() const;
......@@ -133,16 +104,10 @@ public:
/** @brief Get the list of ids whose clip have the resource indicated by @param url */
const QStringList getBinIdsByResource(const QFileInfo &url) const;
void storeMarker(const QString &markerId, const QString &markerHash);
/** @brief A Bin clip effect was changed, update track producers */
void updateTrackProducer(const QString &id);
/** @brief Load thumbnails for all producers */
void checkThumbnails(const QDir &thumbFolder);
/** @brief Request audio thumbnails for all producers */
void checkAudioThumbs();
/** @brief Save document properties in MLT's bin playlist */
void saveDocumentProperties(const QMap<QString, QString> &props, const QMap<QString, QString> &metadata, std::shared_ptr<MarkerListModel> guideModel);
......@@ -182,9 +147,6 @@ private:
/** @brief Remove a clip from MLT's special bin playlist */
void removeBinPlaylistClip(const QString &id);
/** @brief Duplicate effects from stored producer */
void pasteEffects(const QString &id, const std::shared_ptr<Mlt::Producer> &producer);
void requestAudioThumb(const QString &);
void abortAudioThumbs();
......@@ -1502,17 +1502,6 @@ double Render::getMltVersionInfo(const QString &tag)
return version;
Mlt::Producer *Render::getBinProducer(const QString &id)
// TODO refac : delete this function
return m_binController->getBinProducer(id).get();
Mlt::Producer *Render::getBinVideoProducer(const QString &id)
// TODO refac : delete this function
return m_binController->getBinVideoProducer(id);
void Render::loadExtraProducer(const QString &id, Mlt::Producer *prod)
......@@ -222,10 +222,6 @@ class Render : public AbstractRender
bool externalConsumer;
/** @brief Returns the current version of an MLT's producer module */
double getMltVersionInfo(const QString &tag);
/** @brief Get a clip's master producer */
Mlt::Producer *getBinProducer(const QString &id);
/** @brief Get a clip's video only producer */
Mlt::Producer *getBinVideoProducer(const QString &id);
/** @brief Load extra producers (video only, slowmotion) from timeline */
void loadExtraProducer(const QString &id, Mlt::Producer *prod);
/** @brief Get a property from the bin's playlist */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment