Kid3 merge requestshttps://invent.kde.org/multimedia/kid3/-/merge_requests2020-01-12T20:10:00Zhttps://invent.kde.org/multimedia/kid3/-/merge_requests/1Change ‘directory’ to ‘folder’ in user-visible strings2020-01-12T20:10:00ZAdrian ChavesChange ‘directory’ to ‘folder’ in user-visible stringsTry and enforce [consistency in the use of folder-related vocabulary](https://hig.kde.org/style/writing/vocabulary.html#directories-and-folders) in user-visible strings.
To discuss the vocabulary choice criteria itself, please refer t...Try and enforce [consistency in the use of folder-related vocabulary](https://hig.kde.org/style/writing/vocabulary.html#directories-and-folders) in user-visible strings.
To discuss the vocabulary choice criteria itself, please refer to https://invent.kde.org/websites/hig-kde-org/merge_requests/62
(I’ve sent an email to ufleisch@users.sourceforge.net since I could not find his KDE GitLab username)https://invent.kde.org/multimedia/kid3/-/merge_requests/23snapcraft: Set CFG_QMLDIR to fix scripts. Fix dbus name.2023-11-01T04:22:39ZScarlett Mooresgmoore@kde.orgsnapcraft: Set CFG_QMLDIR to fix scripts. Fix dbus name.Dbus name was incorrect. Add cmake flag for qml dir, though this is a runtime issue, not build, we don't have the $SNAP variable available at build time. Set env for this? Will it work?Dbus name was incorrect. Add cmake flag for qml dir, though this is a runtime issue, not build, we don't have the $SNAP variable available at build time. Set env for this? Will it work?https://invent.kde.org/multimedia/kid3/-/merge_requests/22snapcraft: Fix ffmepg build snap. Add missing runtime packages.2023-10-31T05:33:16ZScarlett Mooresgmoore@kde.orgsnapcraft: Fix ffmepg build snap. Add missing runtime packages.Fix the name of the ffmpeg sdk snap and add it to root path so cmake finds it. Add missing runtime packages.Fix the name of the ffmpeg sdk snap and add it to root path so cmake finds it. Add missing runtime packages.https://invent.kde.org/multimedia/kid3/-/merge_requests/21CMakeLists.txt qt6-kf6 find DESTINATION2023-01-21T16:31:49ZMarius PaCMakeLists.txt qt6-kf6 find DESTINATIONFix two CMake issues when compiling using kdesrc-build and qt6-kf6.Fix two CMake issues when compiling using kdesrc-build and qt6-kf6.https://invent.kde.org/multimedia/kid3/-/merge_requests/20Update CMakeLists.txt to allow for translations being in tree.2023-04-02T10:41:27ZCarlos De MaineUpdate CMakeLists.txt to allow for translations being in tree.Update CMakeLists.txt to allow for translations being in tree.Update CMakeLists.txt to allow for translations being in tree.https://invent.kde.org/multimedia/kid3/-/merge_requests/18Fix build on Musl libc2022-09-24T15:47:35ZBart RibbersFix build on Musl libcmalloc_trim is only implemented on glibc, so rather than checking if the
OS is Linux and not Android, check if it's Linux and glibc.malloc_trim is only implemented on glibc, so rather than checking if the
OS is Linux and not Android, check if it's Linux and glibc.https://invent.kde.org/multimedia/kid3/-/merge_requests/17Enable Norwegian Nynorsk translation2022-06-08T19:24:10ZKarl Ove Hufthammerkarl@huftis.orgEnable Norwegian Nynorsk translationThe translation is now at 100%.The translation is now at 100%.Urs FleischUrs Fleischhttps://invent.kde.org/multimedia/kid3/-/merge_requests/16Quote filename in command-line example2022-06-07T19:17:58ZKarl Ove Hufthammerkarl@huftis.orgQuote filename in command-line exampleThe quotes are necessary for proper handling of filenames
that contain spaces.The quotes are necessary for proper handling of filenames
that contain spaces.Urs FleischUrs Fleischhttps://invent.kde.org/multimedia/kid3/-/merge_requests/15Add DSDIFF(dff) to taglibmetadata plugin2022-02-10T09:31:32ZThomas HouAdd DSDIFF(dff) to taglibmetadata pluginUse https://github.com/damien78/taglib' dsdiff code, add to taglibmetadata.
> DSDIFF: ~~manages 'DIIN' chunk (Edited Master Information chunk, for title and artist) as per the DSDIFF 1.5 standard~~, and adds management of an 'ID3 ' (ID3...Use https://github.com/damien78/taglib' dsdiff code, add to taglibmetadata.
> DSDIFF: ~~manages 'DIIN' chunk (Edited Master Information chunk, for title and artist) as per the DSDIFF 1.5 standard~~, and adds management of an 'ID3 ' (ID3v2) chunk as found in popular softwares understanding DSDIFF that store it at either the root level, or for some as a child of the 'PROP' chunkhttps://invent.kde.org/multimedia/kid3/-/merge_requests/13Fix build with FFmpeg 52022-01-26T21:27:42ZAntonio RojasFix build with FFmpeg 5https://invent.kde.org/multimedia/kid3/-/merge_requests/12Make proper json2021-12-24T10:54:20ZAlbert Astals CidMake proper jsonhttps://invent.kde.org/multimedia/kid3/-/merge_requests/11Use include(CTest) and BUILD_TESTING to make Qt5Test and Python optional2021-02-05T06:17:51ZAndreas SturmlechnerUse include(CTest) and BUILD_TESTING to make Qt5Test and Python optionalhttps://invent.kde.org/multimedia/kid3/-/merge_requests/9Use Ctrl-Enter to click OK while editing2020-12-30T16:51:42ZChau DuongUse Ctrl-Enter to click OK while editingThe dialog shown when click **Add** allows entering multiline text, thus pressing Enter does not finish editing, users must leave the keyboard and grab the mouse to finish. This MR add `Ctrl+Enter` to finish without having to touch the k...The dialog shown when click **Add** allows entering multiline text, thus pressing Enter does not finish editing, users must leave the keyboard and grab the mouse to finish. This MR add `Ctrl+Enter` to finish without having to touch the keyboard.https://invent.kde.org/multimedia/kid3/-/merge_requests/8Do not version private libraries.2020-11-01T08:39:03ZVadim Zhukovpersgray@gmail.comDo not version private libraries.Those libraries are "private" to Kid3, and versioning them results in
a wrong feeling of those libraries having a public API. Furthermore,
versioning is done without respect to rules of the environment the Kid3
is built for (e.g., on Ope...Those libraries are "private" to Kid3, and versioning them results in
a wrong feeling of those libraries having a public API. Furthermore,
versioning is done without respect to rules of the environment the Kid3
is built for (e.g., on OpenBSD shared libraries have ".major.minor"
suffix, unlike ".major.minor.patch + symlinks" on Linux).
Thus I propose simply dropping VERSION assignment for kid3-core and
kid3-gui libraries. Less code is always better, isn't it? :)https://invent.kde.org/multimedia/kid3/-/merge_requests/7Fix build on OpenBSD (do not try to call macros with :: prefix).2020-10-10T12:44:14ZVadim Zhukovpersgray@gmail.comFix build on OpenBSD (do not try to call macros with :: prefix).The `fileno()` is a macro on OpenBSD (and that's perfectly valid from POSIX point of view), so the `::fileno(foo)` fails to compile. I've removed `::` prefix from both `fileno()` and `isatty()` calls, since adding it everywhere is a bad ...The `fileno()` is a macro on OpenBSD (and that's perfectly valid from POSIX point of view), so the `::fileno(foo)` fails to compile. I've removed `::` prefix from both `fileno()` and `isatty()` calls, since adding it everywhere is a bad idea due to cases like this happening.https://invent.kde.org/multimedia/kid3/-/merge_requests/6Discogs: Send cookie to request english language2020-07-27T17:19:51ZBaptiste AshkaDiscogs: Send cookie to request english languageBUG: 424700
Sending cookie language2=en seems to always make Discogs send an English response.BUG: 424700
Sending cookie language2=en seems to always make Discogs send an English response.https://invent.kde.org/multimedia/kid3/-/merge_requests/5Discogs: Add year and format to listing2020-07-27T16:45:05ZBaptiste AshkaDiscogs: Add year and format to listingDone to better visualize which release is going to be fetched from the list.
I've split the year and format into 2 regexes in case the order changes, however it has not happened when I was testing this.Done to better visualize which release is going to be fetched from the list.
I've split the year and format into 2 regexes in case the order changes, however it has not happened when I was testing this.https://invent.kde.org/multimedia/kid3/-/merge_requests/4Use AppStream Id in the name, this should fix the kde.org/applications ci2020-04-24T05:48:00ZCarl Schwancarl@carlschwan.euUse AppStream Id in the name, this should fix the kde.org/applications ci