They are the same on Linux (but DataLocation is deprecated). On Windows this enables the use of the roaming path.

NO_CHANGELOG

The extra 7 in KMix don't work, cannot work, cause lots of error
messages in the logs and are patched out downstream because of
that: the comment about NRDEVICES being possibly variable
just doesn't apply on FreeBSD.

Adriaan de Groot authored Oct 05, 2020 and Jonathan Marten committed Oct 12, 2020

This is an example commit of reformatting with the clang-format tool;
it breaks most of git-blame because the existing formatting is
so inconsistent.

Adriaan de Groot authored Oct 05, 2020 and Jonathan Marten committed Oct 12, 2020

This format is copied from kquickcharts, one of the few KDE
projects to have such a formatting file. It is WebKit-ish,
so it matches the KDE Frameworks style fairly well.

While here, match the .editorconfig line length with the
clang-format one.

Adriaan de Groot authored Oct 05, 2020 and Jonathan Marten committed Oct 12, 2020

This is a copy of the config from konsole, which I believe
reflects a fairly common current coding format within the
KDE community: 4-space indents, mostly.

Wrong calling function name given to checkOpResult().

If the combo box is needed the mixer ID was not being set in its
item data, so createPageByID() would not find the mixer.

Eliminate unused header files and declarations
Add createWidgets() for creating the dock widgets
Remove unused code in controlsChange()
Eliminate findAction(), no longer used
Move updateDockMuteAction() into contextMenuAboutToShow(), only used once

It's not useful to pop up the volume control for this action, as there
is no position available and so the very small volume control popup
appears (and often doesn't get noticed by the user) at the top left of
the screen.  Do what would be expected from the action text and open
the main KMix window instead.

It may not have been possible before, but with current Qt5 it seems
to be possible if the focus is set appropriately.  Since the popup
is enclosed in a menu all keystrokes are received, so the global
volume/mute shortcuts also need to be recognised and handled.

CCBUG:206724

This action was removed in 8fec379c.

Canberra only needs to be initialized once, but the QTimer needs to
be instantiated in every instance of Mixer_ALSA.

It now works with PA and ALSA, the most likely other backend, so the
option is enabled in the GUI.  Move around some widgets and reword some
messages to correspond with that.  Ensure that all configuration widgets
have tool tips.

I18N:

Using Canberra (if available) to play the event sound, in the same way
as PulseAudio.  There is no GUI to allow the option to be turned on yet,
but it can be enabled by adding

  VolumeFeedback=true

in the [General] section of kmixrc.

Previously there was a hardcoded list of applications in
Mixer_MPRIS2::getChannelTypeFromPlayerId() which passed special
MixDevice::ChannelType values to MixDevice::channelTypeToIconName().
Now the icon name is found via the application's desktop file, which
is requested from the running application via DBus, and passed directly
to MixDevice.  Icons for audio devices are still managed by MixDevice.

There are some applications which do not provide the DBus interface
to locate their desktop file.  Therefore, there is still a hardcoded
fallback list in Mixer_MPRIS2::getIconNameFromPlayerId() which provides
an icon name.  The MixDevice::ChannelType values for specific
applications are no longer used.

This makes all operations which move the volume in steps - hot keys,
mouse wheel over the system tray icon, and slider page steps - use the
same step value.

Improve the interface between the KMix application and the Volume class,
by adding Volume::setVolumeStep() to set the value.  There is no need for
a getter function since a value can be obtained from Volume::volumeStep().
Eliminates some public static variables that looked like constants.

Add an explanatory tool tip to the Volume Step configuration spin box.

Since every slider is now a VolumeSlider, that class can maintain
the extra data.  Simplifies the implementation of MDWSlider.

If it is intended to have a different appearance or operation of
a slider in the future, then it should be implemented as a derived
class of VolumeSlider.

Rafael Sadowski authored Aug 23, 2020 and Rafael Sadowski committed Sep 16, 2020

OpenBSD do not offer or use an OSS mixer

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fixes https://bugs.debian.org/969255

The immediate deletion caused a crash with PulseAudio and
the replacement Qt mainloop.

BUG:425469

Let MixDeviceWidget::contextMenuEvent() handle the initial creation
and eventual showing of the menu.  Rename the pure virtual showContextMenu()
to createContextMenu() and have it only add the control-specific actions
to the menu.

Remove the "Hide" control action and MixDeviceWidget::setDisabled().
The action was only defined for a MDWEnum and was not accessible in the GUI.
The same effect can be achieved using "Configure Channels".

Correctly separate the internal action name and the user readable text,
so that they show up with readable names in the Global Shortcuts KCM.

Only create volume global shortcuts if the control has adjustable
(playback or capture) volume.

Do not create any shortcuts for a virtual or dynamic control, and do not
show the shortcuts configuration dialogue if it would be empty.

Replace protected MixDeviceWidget data members with access functions.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"