KMix merge requestshttps://invent.kde.org/multimedia/kmix/-/merge_requests2021-08-24T21:47:03Zhttps://invent.kde.org/multimedia/kmix/-/merge_requests/7volumefeedback: guard against null local mixer device2021-08-24T21:47:03ZSteve Leungvolumefeedback: guard against null local mixer deviceThis fixes https://bugs.kde.org/show_bug.cgi?id=436619, as far as I can tell.
I can't really comment on why the pointer would be null, but crashing is definitely bad.This fixes https://bugs.kde.org/show_bug.cgi?id=436619, as far as I can tell.
I can't really comment on why the pointer would be null, but crashing is definitely bad.https://invent.kde.org/multimedia/kmix/-/merge_requests/18Sync QT_MIN_VERSION with KF's REQUIRED_QT_VERSION2022-08-10T10:45:11ZÖmer Fadıl UstaSync QT_MIN_VERSION with KF's REQUIRED_QT_VERSIONIn KF we already looking for 5.15.2
and looking something lower than that
is a bit meaninglessIn KF we already looking for 5.15.2
and looking something lower than that
is a bit meaninglessÖmer Fadıl UstaÖmer Fadıl Ustahttps://invent.kde.org/multimedia/kmix/-/merge_requests/24Align volume by steps to be a factor of volumePercentageStep2024-02-29T15:24:33ZTom Ripleydiscofan420@protonmail.comAlign volume by steps to be a factor of volumePercentageStepCurrently when you change volume by steps, it accumulates errors from each steps.
For example for a span of 88 with a step of 5% it will go:
100 - 95 - 91 - 86 - 82 - 77 - 72 - 68 - 63 - etc
With this PR it will go:
100 - 95 - 91 - 85 ...Currently when you change volume by steps, it accumulates errors from each steps.
For example for a span of 88 with a step of 5% it will go:
100 - 95 - 91 - 86 - 82 - 77 - 72 - 68 - 63 - etc
With this PR it will go:
100 - 95 - 91 - 85 - 80 - 76 - 70 - 66 - 60 - etc
Which is more what I'd expect it to be.
Another issue I encountered is the step from configuration is not changed until KMix is restarted.
Intuitively I'd use Settings::volumePercentageStep() directly in Volume::volumeStep() instead of having a global initialized through Volume::setVolumeStep(), I'm not sure if there is a reason not to?
edit:
Added a commit removing the global.