Commit 83ea0096 authored by Yuri Chornoivan's avatar Yuri Chornoivan
Browse files

Fix minor EBN issues

parent 8d1fb3bf
......@@ -678,7 +678,7 @@ void KMixWindow::recreateGUI(bool saveConfig, const QString& mixerId, bool force
if (guiprof==nullptr)
{
qCWarning(KMIX_LOG) << "Cannot load profile" << profileId;
if (profileId.startsWith("MPRIS2."))
if (profileId.startsWith(QLatin1String("MPRIS2.")))
{
profileId = "MPRIS2.default";
qCDebug(KMIX_LOG) << "For MPRIS2 falling back to" << profileId;
......
......@@ -57,7 +57,7 @@ int Mixer_Backend::close()
// ^^^ Background. before the destructor runs, the C++ runtime changes the virtual pointers to point back
// to the common base class. So what actually runs is not run Mixer_ALSA::close(), but this method.
//
// See http://stackoverflow.com/questions/99552/where-do-pure-virtual-function-call-crashes-come-from?lq=1
// See https://stackoverflow.com/questions/99552/where-do-pure-virtual-function-call-crashes-come-from?lq=1
//
// Comment: IMO this is totally stupid and insane behavior of C++, because you cannot simply cannot call
// the overwritten (cleanup) methods in the destructor.
......
......@@ -52,7 +52,7 @@ protected:
/**
* Derived classes MUST implement this to close the mixer. Do not call this directly, but use shutdown() instead.
* The method cannot be made pure virtual, as we use close() in the destructor, and C++ does not allow this.
* http://stackoverflow.com/questions/99552/where-do-pure-virtual-function-call-crashes-come-from?lq=1
* https://stackoverflow.com/questions/99552/where-do-pure-virtual-function-call-crashes-come-from?lq=1
*
* @return a KMix error code (O=OK).
*/
......
......@@ -1132,7 +1132,7 @@ void MDWSlider::showContextMenu(const QPoint &pos)
// Mixer_PULSE::moveStream() does not record the stream ID in the
// output stream list and hence cannot get its PulseAudio stream index.
// I don't know whether this is a design decision or a PA limitation.
if (mixDevice()->id().endsWith(":event")) m_moveMenu->setEnabled(false);
if (mixDevice()->id().endsWith(QLatin1String(":event"))) m_moveMenu->setEnabled(false);
menu->addMenu( m_moveMenu );
}
......
......@@ -15,7 +15,7 @@
*
* You should have received a copy of the GNU Library General Public
* License along with this program; if not, see
* <http://www.gnu.org/licenses>.
* <https://www.gnu.org/licenses>.
*/
......
......@@ -16,7 +16,7 @@
*
* You should have received a copy of the GNU Library General Public
* License along with this program; if not, see
* <http://www.gnu.org/licenses>.
* <https://www.gnu.org/licenses>.
*/
#ifndef TOGGLETOOLBUTTON_H
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment