GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Also use new header visibility protection prefix KCddb5,
as sadly on case-insensitive filesystems there will be a clash
between the c++ namespace subfolder "KCDDB/" and the old camelcase forwarding
header "Kcddb"

Backward-compat headers are provided supporting version-controlled
warnings & disabling reusing the macros provided by
ecm_generate_export_header

There is no backward-compat file for kcddb_export.h & configbase.h,
it is assumed no 3rd-party explicitly includes those directly.

GIT_SILENT

The headers are in the same folder both in the sources & the install dir,
and the export header is in the same install dir as well.
So relying on the POSIX standard to first check the same dir with ""
includes speeds up the header find (and also ensures own headers are
found first).

GIT_SILENT

GIT_SILENT

GIT_SILENT

From the documentation of QThread::~QThread():
"... Note that deleting a QThread object will not stop the execution of the
 thread it manages. Deleting a running QThread (i.e. isFinished() returns false)
 will probably result in a program crash.
 Wait for the finished() signal before deleting the QThread."

The destructor of class AsyncMusicBrainzLookup currently just deletes the lookup
thread object and does _not_ wait for the running thread to finish.
If it is called while the lookup thread is still running, a crash occurs.

In addition to that, we are leaking the memory of a previously instanciated
lookup thread object if the lookup() method is called multiple times.

To maintain the current behavior of the destructor (non-blocking) and the
lookup() method (always start a new lookup without canceling pending lookups),
solve both issues by making the lookup thread object self-destructive.
As part of the solution the lookup thread is modifed to deliver the lookup results
directly with the "lookupFinished" signal. This has two benefits:
1.) the queued signal-slot connection avoids thread synchronization/locking issues
2.) some class members become obsolete

GIT_SILENT

GIT_SILENT

GIT_SILENT

Also move cmake config generation into src/ folder

GIT_SILENT

GIT_SILENT

NO_CHANGELOG

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

Otherwise the "(disc 2)" part of the test may fail

Required ECM >= 5.38 triggers that

GIT_SILENT

GIT_SILENT