GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENCE

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

In KCompactDisc::cdromDeviceUrl(), if the device name is not in the
description-to-URL map it is assumed to be a device name in the form
"/dev/srN" and is converted to 'passedUrl' for checking against the same
map.  Unfortunately in Qt5 QUrl("/dev/srN") does not return a full URL
including the "file" scheme, so it will not compare equal to any
of the map URLs.  The effect is that defaultCdromDeviceUrl() is used,
which is taken to be the first map entry.  Therefore, if the disc is not
in the first drive, an incorrect device URL will be used and the disc
reading fails.

Use QUrl::fromLocalFile() to generate a correct URL for the device name.

Allow WMlib debugging to be enabled without recompiling KCompactDisc,
by setting the environment variable KCOMPACTDISC_WMLIB_DEBUG.

GIT_SILENT

GIT_SILENT

GIT_SILENT

Use the generic redirect commits.kde.org.

Change discussed on the kde-frameworks-devel list:
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-November/097564.html

Summary:
strdup is an extention to the C standard, timerclear originates from
the BSDs. GNU libc exposes both by default but musl libc requires a
feature flag to get them defined and thus fix libkcompactdisc's
build.

Test Plan: Builds fine with glibc and musl libcs.

Differential Revision: https://phabricator.kde.org/D19615

Summary:
POSIX states [1] that it is in the <strings.h> include file, not
<string.h>. While it's likely pulled in implicitly for glibc, its
absence causes a build error with musl libc
(src/wmlib/cdrom.c:128:33: error: implicit declaration of function
'strcasecmp';).

[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html

Test Plan: Builds fine with glibc and musl libcs.

Differential Revision: https://phabricator.kde.org/D19614

strdup is an extention to the C standard, timerclear originates from
the BSDs. GNU libc exposes both by default but musl libc requires a
feature flag to get them defined and thus fix libkcompactdisc's
build.

POSIX states [1] that it is in the <strings.h> include file, not
<string.h>. While it's likely pulled in implicitly for glibc, its
absence causes a build error with musl libc
(src/wmlib/cdrom.c:128:33: error: implicit declaration of function
'strcasecmp';).

[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html

the problem is in the alsa headers, so also clang needs to work around
it