GitLab

Ref T2438

Also add an extra check for 8bit so we can be a bit more precise in 16bit and higher.

Ref T2438

Ref T2438

The debugging.

Probably not all bugs, but the obvious ones are gone now.

Nothing else understands having hexcode in other spaces anyway.

Ref T2438

So it doesn't flip between colorspaces all the time.

Also fixes a crash in KoDualColorButton

Ref T2438

According to boud, some desktop enviroments have no close button on dialogs.

Ref T2438

Ref 2438

Ref T2438

Also rearranged the widget a lot. The KoColorSetWidget is automatically filled with the first palette in the list(which is, as always, concept cookie), and the palette is saved... right now on leave and accept events, which might not be the most intuitive, but at the least it is saved and loaded correctly.

Neither widget has the color management from the displayrenderer, as that would require me editing those directly.

I would like an eye on said save/load code.
Auditors: rempt

This enables the the display color converter on the internal color selector too.
There are still update and range bugs, the range bugs being tricky and the update bugs being probably due wrong signal being connect, but I am pretty pleased with this.

Ref T2337

I can't get much further here due the inability for kodualcolorbutton
to have a display renderer, due MVC. Fun times...

Ref T2337

Will need to change it now...

These now work fully for the channels. They give nice squares.
I made a base class that only deals with the events and the classes, and added a rectangular subclass. This way we can make our circles and wheels and whatever easily.

Ref T2337
Ref T2438

This is a widget with a button that allows you to select anywhere on the screen. It's not smart enough yet to recognise Krita windows and canvases and to select the color managed value, but it is a nice self contained widget, which I find pretty impressive already.

Ref T2337, T2838

Ref T2337 T2438

So right now, KoDualColorButton has Non-modal mode on the foreground color and modal mode on the background color.

Also contains a lot of cleanup, the UI files for example now working
properly.

Ref T2337 T2438

This makes the updating of the spinboxes much easier. Might
be using this method more commonly.

Ref T2337, T2438

It doesn't crash, it updates, gets updated, can select colors, wide gamut colors, changes configuration based
on selected color's color space... It still needs to be cleaned up and have fluid updating. Also 90% of the rest of
the selector, but I first want to get this updating slot signal mess clean.

Can I keep using QObject::sender()? It's making my life very easy.

Auditors: rempt
Ref T2337, T2438

Right now the spinbox widget is able to adapt itself to all colorspaces, and having it
as a separate widget makes it into a nice building block for other uses too.

I can't actually connect this to anything, because all our color buttons seem to be K and Ko,
so that will be the big task tomorrow...

Ref: T2337, T2438
Auditors: rempt