From 619f6102318abe82a27eed399ebf9e3d66f407d0 Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Mon, 26 Oct 2020 14:40:33 +0100
Subject: [PATCH] [kcm] Show account creation error in the UI

Display the error message we get from the account creation job in the UI instead of silently failing.

CCBUG: 420280
---
 .../package/contents/ui/AvailableAccounts.qml   | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/kcm/package/contents/ui/AvailableAccounts.qml b/src/kcm/package/contents/ui/AvailableAccounts.qml
index c6e4197..3968120 100644
--- a/src/kcm/package/contents/ui/AvailableAccounts.qml
+++ b/src/kcm/package/contents/ui/AvailableAccounts.qml
@@ -18,6 +18,13 @@ ScrollViewKCM {
     id: root
     title: i18n("Add New Account")
 
+    header: Kirigami.InlineMessage {
+        id: errorMessage
+        type: Kirigami.MessageType.Error
+        showCloseButton: true
+        visible: false
+    }
+
     view: ListView {
 
         clip: true
@@ -96,7 +103,15 @@ ScrollViewKCM {
     Component {
         id: jobComponent
         KAccounts.CreateAccountJob {
-            onFinished: kcm.pop()
+            onFinished: {
+                // Don't close when there is an error to show an error message
+                if (error == 0) {
+                    kcm.pop()
+                } else {
+                    errorMessage.text = errorText
+                    errorMessage.visible = true
+                }
+            }
         }
     }
 }
-- 
GitLab