Commit 2420b04e authored by Dan Leinir Turthra Jensen's avatar Dan Leinir Turthra Jensen 🌈
Browse files

Unbreak the Accounts KCM

Summary:
Prior to this, the Accounts KCM would show only the first account,
because the listview was a zero by zero size (which results in
the first item still being shown because labels will overpaint
unless told otherwise). The reson it looked like there was a
view there before was that the view was set to the ScrollViewKCM's
default scroll view. In other words: All the accounts were in fact
there, but they were not displayed because the listview was
not there.

BUG:415267

Reviewers: #plasma, nicolasfella, bshah

Reviewed By: #plasma, bshah

Subscribers: arojas

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27454
parent fd98ccf1
......@@ -34,7 +34,7 @@ ScrollViewKCM {
id: kaccountsRoot
// Existing accounts
ListView {
view: ListView {
model: OA.AccountServiceModel {
id: accountsModel
service: "global"
......@@ -45,7 +45,7 @@ ScrollViewKCM {
width: ListView.view.width
contentItem: Controls.Label {
text: i18n("%1 (%2)", model.displayName, providerName)
text: i18n("%1 (%2)", model.displayName, model.providerName)
OA.Account {
id: account
......
......@@ -29,9 +29,7 @@ ScrollViewKCM {
id: root
title: i18n("Add new Account")
ListView {
anchors.fill: parent
view: ListView {
model: OA.ProviderModel {}
delegate: Kirigami.BasicListItem {
......
......@@ -31,8 +31,7 @@ ScrollViewKCM {
property alias accountId: servicesModel.accountId
ListView {
anchors.fill: parent
view: ListView {
model: OA.AccountServiceModel {
id: servicesModel
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment