Commit 7c56aa9c authored by Albert Vaca Cintora's avatar Albert Vaca Cintora

Error handling

parent 4ea76188
...@@ -62,7 +62,7 @@ public class DeviceHelper { ...@@ -62,7 +62,7 @@ public class DeviceHelper {
//It returns getAndroidDeviceName() if no user-defined name has been set with setDeviceName(). //It returns getAndroidDeviceName() if no user-defined name has been set with setDeviceName().
public static String getDeviceName(Context context) { public static String getDeviceName(Context context) {
SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(context); SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(context);
// Could use prefrences.contains but would need to check for empty String anyway. // Could use preferences.contains but would need to check for empty String anyway.
String deviceName = preferences.getString(KEY_DEVICE_NAME_PREFERENCE, ""); String deviceName = preferences.getString(KEY_DEVICE_NAME_PREFERENCE, "");
if (deviceName.isEmpty()) { if (deviceName.isEmpty()) {
if (!fetchingName) { if (!fetchingName) {
...@@ -77,10 +77,16 @@ public class DeviceHelper { ...@@ -77,10 +77,16 @@ public class DeviceHelper {
private static void backgroundFetchDeviceName(final Context context) { private static void backgroundFetchDeviceName(final Context context) {
DeviceName.with(context).request((info, error) -> { DeviceName.with(context).request((info, error) -> {
fetchingName = false; fetchingName = false;
if (error != null) {
Log.e("DeviceHelper", "Error fetching device name");
error.printStackTrace();
}
if (info != null) {
String deviceName = info.getName(); String deviceName = info.getName();
Log.i("DeviceHelper","Got device name: "+deviceName); Log.i("DeviceHelper", "Got device name: " + deviceName);
// Update the shared preference. Places that display the name should be listening to this change and update it // Update the shared preference. Places that display the name should be listening to this change and update it
setDeviceName(context, deviceName); setDeviceName(context, deviceName);
}
}); });
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment