refactor getTickerText

dbd9ece1 · Nicolas Fella · 132e4e7e · dbd9ece1
Commit dbd9ece1 authored Jun 04, 2019 by Nicolas Fella
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 21 deletions

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java ...nect/Plugins/NotificationsPlugin/NotificationsPlugin.java +17 -21

No files found.
--- a/src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java
+++ b/src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java
@@ -489,32 +489,28 @@ public class NotificationsPlugin extends Plugin implements NotificationReceiver.
     * instead the ticker text.
     */
    private String getTickerText(Notification notification) {
-        final String TITLE_KEY = "android.title";
-        final String TEXT_KEY = "android.text";
        String ticker = "";

-        if (notification != null) {
-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
-                try {
-                    Bundle extras = notification.extras;
-                    String extraTitle = extractStringFromExtra(extras, TITLE_KEY);
-                    String extraText = extractStringFromExtra(extras, TEXT_KEY);
-
-                    if (extraTitle != null && extraText != null && !extraText.isEmpty()) {
-                        ticker = extraTitle + ": " + extraText;
-                    } else if (extraTitle != null) {
-                        ticker = extraTitle;
-                    } else if (extraText != null) {
-                        ticker = extraText;
-                    }
-                } catch (Exception e) {
-                    Log.e(TAG, "problem parsing notification extras for " + notification.tickerText, e);
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
+            try {
+                Bundle extras = notification.extras;
+                String extraTitle = extractStringFromExtra(extras, Notification.EXTRA_TITLE);
+                String extraText = extractStringFromExtra(extras, Notification.EXTRA_TEXT);
+
+                if (extraTitle != null && extraText != null && !extraText.isEmpty()) {
+                    ticker = extraTitle + ": " + extraText;
+                } else if (extraTitle != null) {
+                    ticker = extraTitle;
+                } else if (extraText != null) {
+                    ticker = extraText;
                }
+            } catch (Exception e) {
+                Log.e(TAG, "problem parsing notification extras for " + notification.tickerText, e);
            }
+        }

-            if (ticker.isEmpty()) {
-                ticker = (notification.tickerText != null) ? notification.tickerText.toString() : "";
-            }
+        if (ticker.isEmpty()) {
+            ticker = (notification.tickerText != null) ? notification.tickerText.toString() : "";
        }

        return ticker;