1. 28 Apr, 2019 1 commit
  2. 08 Apr, 2019 1 commit
  3. 24 Feb, 2018 1 commit
    • Matthijs Tijink's avatar
      Add MPRIS media control notification · 2f127b30
      Matthijs Tijink authored
      Summary:
      BUG: 337485
      
      Adds a notification to show and control mpris players. It shows the title, artist etc. (so depends on D9083, but can easily be adapted to work without it, but that leads to less features).
      
      The notification appears as soon as one of your connected devices plays music. If multiple devices/players are playing, it shows the information and controls for only one of these. If it stops playing, it tries to switch to another playing device/player. If those do not exist, it shows the same player, but allows starting it again.
      
      Dismissing the notification is only possible if the showed player is paused (as effect, only when all players are paused). It automatically closes if the device or player disappears or disconnects and no other players are playing. I think this behaviour is intuitive, other native android music players have similar behaviour.
      
      About the implementation: there are two parts to this: the notification and the media session control API. The first shows the notification and its controls. The second allows lock screen controls on older Android versions and control using e.g. headphone buttons. Since nearly all code is shared between the two parts, and the rest is mostly straightforward, I put them in the same diff.
      
      Test Plan:
      Tested on Android Nougat 7.1 (shows the notification with buttons, as expected; no lock screen controls, as expected) and Android Gingerbread 2.3 (shows a notification without buttons, lock screen controls work, so as expected).
      
      I am not able to test with multiple desktops, so testing that would be appreciated.
      
      Disabling buttons when not available should work, but all players I tested always allowed next/previous/play/pause.
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, albertvaka, nicolasfella
      
      Tags: #kde_connect
      
      Maniphest Tasks: T6512
      
      Differential Revision: https://phabricator.kde.org/D9266
      2f127b30
  4. 01 Dec, 2017 1 commit
    • Matthijs Tijink's avatar
      Use material icons in MPRIS activity · 044261ce
      Matthijs Tijink authored
      Summary: The previous icons were old (pre-Material, maybe even pre-Holo). The recommended practice now is to add the icons directly to your app, so I added the material icons. Note that the vector version is used; these are automatically converted to bitmaps for older android versions.
      
      Reviewers: #kde_connect
      
      Subscribers: apol
      
      Differential Revision: https://phabricator.kde.org/D8955
      044261ce