Skip to content

GitLab

Switch branch/tag
  1. 19 Jan, 2019 1 commit
  3. 18 Jan, 2019 2 commits
  5. 17 Jan, 2019 1 commit
    • Erik Duisters's avatar
      Use androidx version of AlertDialog · 8e93e325
      Erik Duisters authored 
      Summary:
Use androidx version of AlertDialog to get properly styled AlertDialog buttons
Use PreferenceManager context to style Device Name AlertDialog

|{F6551907}|{F6551908}|
|Before|After|

Test Plan: Apply patch and verify that AlertDialogs have properly styled buttons

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D18298
      8e93e325
  7. 16 Jan, 2019 2 commits
    • Piyush Aggarwal's avatar
      Allow disabling persistent notification in Android 8.0 and up · a6ae97af
      Piyush Aggarwal authored 
      Summary:
`Show persistent notification` toggle is disabled from Android O and up
This patch aims to enable the toggle with link to Notifications Settings, so that user can itself disable the persistent notification if desired

Test Plan: Apply patch, use on Android O or up device and use `Show persistent notification` toggle. It should take you to Notifications settings page of KDE Connect

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, eduisters, nicolasfella, kdeconnect, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D18181
      a6ae97af
    • Erik Duisters's avatar
      Update for Android Studio 3.3 · 8466a6f8
      Erik Duisters authored 
      Summary:
Update gradle-plugin to v3.3.0
Update gradle 4.10.1-all
Update Butterknife to v10.0.0

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D18264
      8466a6f8
  9. 14 Jan, 2019 1 commit
  11. 11 Jan, 2019 1 commit
  13. 10 Jan, 2019 1 commit
  15. 09 Jan, 2019 1 commit
  17. 08 Jan, 2019 2 commits
    • Erik Duisters's avatar
      Switch to MaterialComponents theme · 72026d94
      Erik Duisters authored 
      Summary:
Androidx introduced new Materialcomponents themes, use them instead of
Theme.AppCompat. This also causes AlertDialogs and PreferenceDialogFragments
to be styled correctly

|{F6531506}|{F6531505}|
|Before|After|

(Ok button is disabled if you are wondering)

Test Plan: Apply patch, verify everything still looks as expected

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D18039
      72026d94
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 47254567
      Script Kiddy authored
      47254567
  19. 07 Jan, 2019 1 commit
  21. 06 Jan, 2019 5 commits
    • Erik Duisters's avatar
      Make tapping on a pair notification work again · 41733389
      Erik Duisters authored 
      Summary:
The Simplify pairing from notification patch D16518 broke the functionality that
tapping on the notification provided

This patch makes tapping on the pairing notification work again as expected

Test Plan:
Before applying this patch initiate a pairing from kde
On android tap on the notification (not the action buttons) and notice that nothing happens

Apply the path and repeat the above test. Now the DeviceFragment should be displayed allowing
the the pairing to be accepted or rejected

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17886
      41733389
    • Erik Duisters's avatar
      Use ButterKnife for view binding · ebdc040c
      Erik Duisters authored 
      Summary: Use ButterKnife for view binding

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17878
      ebdc040c
    • Erik Duisters's avatar
      Do not continue displaying the previous track's album art image when the new... · abba7f11
      Erik Duisters authored 
      Do not continue displaying the previous track's album art image when the new track's albumArtUrl is empty

Summary:
When a new track starts playing and does not have album art the previously displayed
album art image will be displayed until a new track starts playing that does have
album art

Test Plan:
Before applying this patch play a track that has album art followed by a song
that does not have album art. Notice that when the track without album art starts
playing the album art of the previous track is still displayed

Apply patch, repeat previous test and notice that the album art placeholder is displayed
when the track without album art start playing

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17875
      abba7f11
    • Erik Duisters's avatar
      Migrate from PreferenceActivity to PreferenceFragment because it has been... · 9fb780f9
      Erik Duisters authored 
      Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11

Summary:
PreferenceActivity has been deprecated since Android 3.0 API 11 in favour of PreferenceFragment

| {F6515113} | {F6515114}|
|Before|
| {F6515111} | {F6515112}|
|After|

Test Plan:
Apply patch and observe that the DeviceSettings and PluginSettings screen behave as expected
and now also follow material design guidelines

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17859
      9fb780f9
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 045e329b
      Script Kiddy authored
      045e329b
  23. 01 Jan, 2019 1 commit
  25. 30 Dec, 2018 1 commit
  27. 29 Dec, 2018 1 commit
  29. 28 Dec, 2018 1 commit
  31. 27 Dec, 2018 2 commits
  33. 26 Dec, 2018 1 commit
  35. 25 Dec, 2018 2 commits
  37. 24 Dec, 2018 13 commits