Skip to content
Commit bcf080f6 authored by Simon Redman's avatar Simon Redman
Browse files

[SMS Plugin] Change android-smsmms to in-house build until upstream supports SDK31 

## Summary

Android apps which target SDK 31+ require specifying the mutability of any PENDING_INTENT. This is not supported in the upstream android-smsmms library: https://github.com/klinker41/android-smsmms/pull/193

Until the above PR is merged, we need a solution. I have pulled the code into https://invent.kde.org/sredman/android-smsmms and published the package in the Maven repository in gitlab.

BUG: 464392

## Test Plan

### Before:
Attempting to send an SMS or MMS message using kdeconnect-sms results in no message being sent, and an error being logged:

> V/Sending message: Sending new SMS
> E/Sending message: Exception
>     java.lang.IllegalArgumentException: org.kde.kdeconnect_tp: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
>     Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on t...
parent 9db4c885
Hide whitespace changes
Inline Side-by-side
  • ori chalcum @orichalcum ·

    Seems that f-droid kde-connect upgrade is stuck because https://invent.kde.org/api/v4/projects/72/packages/maven is inaccessible (not public)

  • Simon Redman @sredman ·
    Author Developer

    That error is not due to accessibility of the maven repo. It is public (you could run the build yourself locally and test). The error is due to f-droid's policy to ensure no non-FOSS software is in their store. We need to reach out to them to see if they will allow Maven packages invent.kde.org. I hope they should, since KDE policy is aligned in the sense that all KDE software must be open-source.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment