Commit 8112729e authored by Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez 🐧 Committed by Albert Vaca Cintora
Browse files

Don't brute-force reading the socket

The package will arrive eventually, and dataReceived will be emitted.
Otherwise we just end up calling dataReceived to no end.

Thanks Matthias Gerstner <> for reporting this.
parent 024e5f23
......@@ -24,14 +24,6 @@ void SocketLineReader::dataReceived()
//If we still have things to read from the socket, call dataReceived again
//We do this manually because we do not trust readyRead to be emitted again
//So we call this method again just in case.
if (m_socket->bytesAvailable() > 0) {
QMetaObject::invokeMethod(this, "dataReceived", Qt::QueuedConnection);
//If we have any packets, tell it to the world.
if (!m_packets.isEmpty()) {
Q_EMIT readyRead();
......@@ -13,16 +13,19 @@
#include <QProcess>
#include <QEventLoop>
#include <QTimer>
#include <QSignalSpy>
class TestSocketLineReader : public QObject
public Q_SLOTS:
void initTestCase();
void init();
void cleanup() { delete m_server; }
void newPacket();
private Q_SLOTS:
void socketLineReader();
void badData();
QTimer m_timer;
......@@ -33,8 +36,9 @@ private:
SocketLineReader* m_reader;
void TestSocketLineReader::initTestCase()
void TestSocketLineReader::init()
m_server = new Server(this);
QVERIFY2(m_server->listen(QHostAddress::LocalHost, 8694), "Failed to create local tcp server");
......@@ -85,6 +89,29 @@ void TestSocketLineReader::socketLineReader()
void TestSocketLineReader::badData()
const QList<QByteArray> dataToSend = { "data1\n", "data" }; //does not end in a \n
for (const QByteArray& line : qAsConst(dataToSend)) {
QSignalSpy spy(m_server, &QTcpServer::newConnection);
QVERIFY(m_server->hasPendingConnections() || spy.wait(1000));
QSslSocket* sock = m_server->nextPendingConnection();
QVERIFY2(sock != nullptr, "Could not open a connection to the client");
m_reader = new SocketLineReader(sock, this);
connect(m_reader, &SocketLineReader::readyRead, this, &TestSocketLineReader::newPacket);
QCOMPARE(m_packets.count(), 1);
QCOMPARE(m_packets[0], dataToSend[0]);
void TestSocketLineReader::newPacket()
int maxLoops = 5;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment