Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit d58f6cf2 authored by Nicolas Fella's avatar Nicolas Fella

Remove unused code in NotificationDbusInterface

Summary: The isRequest codepath is never used. The requestAnswer path is not implemented and after D9558 not needed anymore.

Test Plan: Sending notifications works like before

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, #kde_connect

Differential Revision: https://phabricator.kde.org/D9559
parent 2aeae445
......@@ -64,19 +64,6 @@ void NotificationsDbusInterface::processPackage(const NetworkPackage& np)
if (id.startsWith(QLatin1String("org.kde.kdeconnect_tp::")))
id = id.mid(id.indexOf(QLatin1String("::")) + 2);
removeNotification(id);
} else if (np.get<bool>(QStringLiteral("isRequest"))) {
for (const auto& n : qAsConst(m_notifications)) {
NetworkPackage np(PACKAGE_TYPE_NOTIFICATION_REQUEST, {
{"id", n->internalId()},
{"appName", n->appName()},
{"ticker", n->ticker()},
{"isClearable", n->dismissable()},
{"requestAnswer", true}
});
m_plugin->sendPackage(np);
}
} else if(np.get<bool>(QStringLiteral("requestAnswer"), false)) {
} else {
QString id = np.get<QString>(QStringLiteral("id"));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment