1. 07 Oct, 2018 1 commit
    • Simon Redman's avatar
      Correct braces and add contributors · 563dde98
      Simon Redman authored
      Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line
      
      Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15978
      563dde98
  2. 05 Oct, 2018 1 commit
  3. 04 Oct, 2018 2 commits
  4. 30 Sep, 2018 1 commit
  5. 29 Sep, 2018 1 commit
  6. 28 Sep, 2018 2 commits
    • Nicolas Fella's avatar
      [cli] Allow sharing files and URLs together · 7a4bdcc6
      Nicolas Fella authored
      Summary:
      Depends on D15787
      
      Restricting sharing multiple urls to files seems unnecessary to me.
      
      Test Plan: kdeconnect-cli --share foo.txt google.com
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15788
      7a4bdcc6
    • Nicolas Fella's avatar
      [cli] Always take working dir into account when parsing url · 51825134
      Nicolas Fella authored
      Summary:
      Bug: 399115
      
      When using kdeconnect-cli --share the first argument was not recognised as a file when a relative path was specified.
      
      Test Plan:
      kdeconnect-cli --share File1.txt File2.txt : Check that both files are sent
      kdeconnect-cli --sahre phabricator.kde.org : Check that web page is opend
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15787
      51825134
  7. 27 Sep, 2018 3 commits
  8. 24 Sep, 2018 2 commits
  9. 22 Sep, 2018 1 commit
  10. 19 Sep, 2018 1 commit
  11. 18 Sep, 2018 1 commit
  12. 16 Sep, 2018 3 commits
    • Simon Redman's avatar
      [Desktop] Allow SMS app to handle newly recieved messages · 23d931cb
      Simon Redman authored
      Summary:
      Update sms app model to use new conversationUpdated signal
      
      Filter incoming messages which belong to a different conversation than the one currently being viewed
      
      See Android-side diff D15360 which adds support for sending live updates when a new message is sent or received
      
      Test Plan:
      This patch relies on D15360 for Android-side support
        - Positive case:
          - Open a conversation in the SMS app
          - Receive a new message into that conversation (text yourself?)
          - Verify that the new message appears at the bottom of the appropriate conversation
        - Negative case:
          - Open a conversation in the SMS app
          - Receive a new message into a different conversation (text yourself?)
          - Verify that the new message does *not* appear in the open conversation
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15409
      23d931cb
    • Simon Redman's avatar
      [Desktop] SMS plugin no longer creates desktop notifications -- Old... · 64062b3c
      Simon Redman authored
      [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin
      
      Summary:
      Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway
      
      Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_*
      
      Update TELEPHONY plugin packet description to point to SMS plugin
      
      Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field
      
      Please see Android-side patch here: D15544
      
      Test Plan:
      I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision:
       - New Android vs. New Desktop
         - Supported and works for me
       - New Android vs. Old Desktop
         - Supported and works for me
       - Old Android vs. New Desktop
         - Not supported - Download a new app from the Play store or F-Droid
       - Old Android vs. Old Desktop
         - If this is broken, it is not my fault :)
      
      In the supported use cases:
       - Test SMS reply
         - Receive SMS (or MMS!) message
         - Verify that the //notification// plugin forwards a replyable notification and that replying works
       - Test incoming call ringer mute
         - Enable ringer volume (not vibrate)
         - Receive phone call
         - Verify a desktop notification with a Mute button appears
         - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected)
      
      Reviewers: #kde_connect, albertvaka, nicolasfella
      
      Reviewed By: #kde_connect, albertvaka, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15543
      64062b3c
    • Simon Redman's avatar
      Set view to track new elements as they are added · d742684d
      Simon Redman authored
      Summary: Set the currentIndex of the ConversationDisplay to show the newest messages by default, but stay where the user positioned it if viewing older messages
      
      Test Plan:
      Launch SMS App:
       - Select conversation
       - View should show the most recent messages
       - Receive new message
       - View should scroll to show the new message
       - Scroll up to view older messages
       - Receive new message
       - View should continue to show older messages and not scroll to the bottom
      
      Reviewers: nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15562
      d742684d
  13. 15 Sep, 2018 1 commit
  14. 14 Sep, 2018 1 commit
  15. 13 Sep, 2018 2 commits
  16. 12 Sep, 2018 2 commits
  17. 11 Sep, 2018 1 commit
  18. 10 Sep, 2018 2 commits
    • Nicolas Fella's avatar
      Use better icon for contactsplugin · 3b91acf0
      Nicolas Fella authored
      3b91acf0
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored
      Summary:
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: sredman
      
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13594
      bcc9fb06
  19. 08 Sep, 2018 1 commit
    • Simon Redman's avatar
      Sort Cached Messages · e5b6c147
      Simon Redman authored
      Summary: Previously, incoming messages were appened to a QList. This list was accidentally sorted because that's how Android returned them, but new messages were appended to the wrong end of the list. This patch specifically and intentionally sorts messages so new ones become visible
      
      Test Plan:
      - Open SMS GUI, verify that the most-recent messages are shown
      - Either send or recieve an SMS
      - Wait about 5s (I do not know why this is necessary. Probably some Android weirdness)
      - De-select the current conversation, then re-select it
        - TODO: Make the app automatically respond to new messages
      - The newly sent or recieved message should be shown in the most-recent position
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15108
      e5b6c147
  20. 07 Sep, 2018 4 commits
  21. 06 Sep, 2018 7 commits