1. 07 Oct, 2018 1 commit
    • Simon Redman's avatar
      Correct braces and add contributors · 563dde98
      Simon Redman authored
      Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line
      
      Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15978
      563dde98
  2. 16 Sep, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Allow SMS app to handle newly recieved messages · 23d931cb
      Simon Redman authored
      Summary:
      Update sms app model to use new conversationUpdated signal
      
      Filter incoming messages which belong to a different conversation than the one currently being viewed
      
      See Android-side diff D15360 which adds support for sending live updates when a new message is sent or received
      
      Test Plan:
      This patch relies on D15360 for Android-side support
        - Positive case:
          - Open a conversation in the SMS app
          - Receive a new message into that conversation (text yourself?)
          - Verify that the new message appears at the bottom of the appropriate conversation
        - Negative case:
          - Open a conversation in the SMS app
          - Receive a new message into a different conversation (text yourself?)
          - Verify that the new message does *not* appear in the open conversation
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15409
      23d931cb
  3. 10 Sep, 2018 1 commit
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored
      Summary:
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: sredman
      
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13594
      bcc9fb06
  4. 08 Sep, 2018 1 commit
    • Simon Redman's avatar
      Sort Cached Messages · e5b6c147
      Simon Redman authored
      Summary: Previously, incoming messages were appened to a QList. This list was accidentally sorted because that's how Android returned them, but new messages were appended to the wrong end of the list. This patch specifically and intentionally sorts messages so new ones become visible
      
      Test Plan:
      - Open SMS GUI, verify that the most-recent messages are shown
      - Either send or recieve an SMS
      - Wait about 5s (I do not know why this is necessary. Probably some Android weirdness)
      - De-select the current conversation, then re-select it
        - TODO: Make the app automatically respond to new messages
      - The newly sent or recieved message should be shown in the most-recent position
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15108
      e5b6c147
  5. 09 Jun, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
      Aleix Pol Gonzalez authored
      Summary:
      For real usecases of SMS support, we will almost always need access to the message history in some way
      
      Specifically resolve T8338
      
      Incidentally resolve T6651 since Telephony shall no longer create a notification
      
      Test Plan:
      Setup:
      - Build corresponding Android-side diff (D11698)
      - Build this diff
      
      Step 1: Does anything at all work?
      - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
      - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
      - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
      
      Step 2: DBus
      - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
      - Poke activeConversations and verify an empty array is returned
      - Poke requestAllConversationThreads
      - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
      - Use a conversationId to call getFirstFromConversation
        - Verify that the returned Message object is one which you recognize
        - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
      
      Step 3: SMS App
      - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
      - Build the project
      - Run ./bin/kdeconnect-sms
      - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
        - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: andyholmes, apol, nicolasfella, #kde_connect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8338, T6651
      
      Differential Revision: https://phabricator.kde.org/D11854
      31e93ef7