1. 18 Oct, 2020 1 commit
  2. 31 Aug, 2020 1 commit
  3. 23 Aug, 2020 1 commit
  4. 17 Aug, 2020 1 commit
  5. 29 Jul, 2020 2 commits
  6. 08 Jul, 2020 1 commit
  7. 26 May, 2020 1 commit
    • Antonio Larrosa Jimenez's avatar
      Use ecm_qt_declare_logging_category to declare the logging categories · 1d361642
      Antonio Larrosa Jimenez authored
      This automatizes the generation of logging categories so a
      kdeconnect-kde.categories is generated and installed to
      /usr/share/qlogging-categories5/ so kdebugsettings can use it.
      
      Also, sets the default logging level to Warning. So now the logs
      of users won't be filled with debug messages but they can
      modify the configuration easily with kdebugsettings.
      1d361642
  8. 18 May, 2020 1 commit
  9. 07 Apr, 2020 1 commit
  10. 21 Mar, 2020 1 commit
    • Aniket Kumar's avatar
      Add feature to start new conversation with existing contacts · f211d7e4
      Aniket Kumar authored
      ## Summary
      
      Start a conversation with contacts having no previous conversation with.
      
      It is currently only possible to use the messaging app to send a message to a conversation which already exists.
      
      This patch implements this feature by integrating all contacts having no prior conversation with the recent conversations in the recent conversation list and at the bottom in a sorted manner, something like this,
      
      The contacts are stored in the recent conversation list model as a conversation but with INVALID conversation ID and INVALID conversation DATE.
      
      ## Testing
      
      Testing just needs kdeconnect daemon to be recompiled and executed.
      f211d7e4
  11. 29 Jul, 2019 1 commit
  12. 19 Jul, 2019 1 commit
  13. 01 May, 2019 2 commits
  14. 29 Mar, 2019 1 commit
  15. 23 Mar, 2019 1 commit
  16. 07 Mar, 2019 1 commit
  17. 23 Jan, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Make sms app not crash when conversation is selected with no devices connected · a14b39d5
      Simon Redman authored
      Summary: This patch fixes T10184 and stops the SMS app from crashing when a conversation is selected but no devices are connected. It also allows the SMS app to access the cached messages in the ConversationsDbusInterface so the app is still slightly useful even when the device is disconnected.
      
      Test Plan:
      - Open sms app
      - Open a few conversations
      - Disconnect phone (Force close app?)
      - Re-open a conversation which was previously opened
        - Verify that the messages appear. It is possible to scroll up to view any older cached messages too!
      - Open a conversation which was not opened previously
        - Verify that a single messages is shown (since this was the only one in cache, from populating the list of all conversations)
        - Verify that attempting to scroll this conversation does nothing, but also does not crash the app
      
      Note: Opening the app with no phone connected will cause it to lose its handle on the deviceId, so it can't spawn a new Dbus interface, so it will remain blank and empty. Solving that is a project for another day.
      
      Reviewers: #kde_connect
      
      Reviewed By: #kde_connect
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T10184
      
      Differential Revision: https://phabricator.kde.org/D17634
      a14b39d5
  18. 14 Dec, 2018 1 commit
  19. 13 Dec, 2018 2 commits
    • Simon Redman's avatar
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  20. 08 Oct, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Update conversation list when a new message arrives · a7db3ab5
      Simon Redman authored
      Summary:
      When a new message is delivered, the conversation list should update by changing the preview text and re-sorting the conversations
      
      Bonus bug discovered and fixed:  previously, when the conversations list was being populated, it made a request for the first message in every conversation. This would be fine if the conversationdbusinterface pulled from local cache. However, this actually triggers a request to the phone for *every* conversation.
      
      This should be handled differently in conversationdbusinterface's requestConversation as well, but that's a project for a later day (TODO comments added)
      
      Test Plan:
       - Launch SMS app
       - Verify conversations list appears
       - Verify lack of massive stream of debug output indicating lots of messages for the wrong conversation are being received
       - Verify that opening a particular conversation shows the messages after a short delay while the backend fetches the content from the phone
       - Verify that receiving a new message into an existing conversation updates the conversation list
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15608
      a7db3ab5
  21. 07 Oct, 2018 1 commit
    • Simon Redman's avatar
      Correct braces and add contributors · 563dde98
      Simon Redman authored
      Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line
      
      Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15978
      563dde98
  22. 16 Sep, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Allow SMS app to handle newly recieved messages · 23d931cb
      Simon Redman authored
      Summary:
      Update sms app model to use new conversationUpdated signal
      
      Filter incoming messages which belong to a different conversation than the one currently being viewed
      
      See Android-side diff D15360 which adds support for sending live updates when a new message is sent or received
      
      Test Plan:
      This patch relies on D15360 for Android-side support
        - Positive case:
          - Open a conversation in the SMS app
          - Receive a new message into that conversation (text yourself?)
          - Verify that the new message appears at the bottom of the appropriate conversation
        - Negative case:
          - Open a conversation in the SMS app
          - Receive a new message into a different conversation (text yourself?)
          - Verify that the new message does *not* appear in the open conversation
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15409
      23d931cb
  23. 10 Sep, 2018 1 commit
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored
      Summary:
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: sredman
      
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13594
      bcc9fb06
  24. 08 Sep, 2018 1 commit
    • Simon Redman's avatar
      Sort Cached Messages · e5b6c147
      Simon Redman authored
      Summary: Previously, incoming messages were appened to a QList. This list was accidentally sorted because that's how Android returned them, but new messages were appended to the wrong end of the list. This patch specifically and intentionally sorts messages so new ones become visible
      
      Test Plan:
      - Open SMS GUI, verify that the most-recent messages are shown
      - Either send or recieve an SMS
      - Wait about 5s (I do not know why this is necessary. Probably some Android weirdness)
      - De-select the current conversation, then re-select it
        - TODO: Make the app automatically respond to new messages
      - The newly sent or recieved message should be shown in the most-recent position
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15108
      e5b6c147
  25. 09 Jun, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
      Aleix Pol Gonzalez authored
      Summary:
      For real usecases of SMS support, we will almost always need access to the message history in some way
      
      Specifically resolve T8338
      
      Incidentally resolve T6651 since Telephony shall no longer create a notification
      
      Test Plan:
      Setup:
      - Build corresponding Android-side diff (D11698)
      - Build this diff
      
      Step 1: Does anything at all work?
      - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
      - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
      - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
      
      Step 2: DBus
      - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
      - Poke activeConversations and verify an empty array is returned
      - Poke requestAllConversationThreads
      - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
      - Use a conversationId to call getFirstFromConversation
        - Verify that the returned Message object is one which you recognize
        - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
      
      Step 3: SMS App
      - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
      - Build the project
      - Run ./bin/kdeconnect-sms
      - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
        - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: andyholmes, apol, nicolasfella, #kde_connect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8338, T6651
      
      Differential Revision: https://phabricator.kde.org/D11854
      31e93ef7