1. 03 Sep, 2017 1 commit
    • Jean Vincent's avatar
      Make member variable names, & placement and * placement more coherent · 72535ecf
      Jean Vincent authored
      Summary:
      Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
      Place all references and pointers on the side of the type since it is the majority.
      
      Basically:
       - mFoo -> m_foo
       - foo -> m_foo (if it is a member variable)
       - Type &ref -> Type& ref
       - Type *ptr -> Type* ptr
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      
      Subscribers: albertvaka, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D7312
      72535ecf
  2. 22 Aug, 2017 1 commit
  3. 13 Aug, 2017 1 commit
  4. 06 Aug, 2017 1 commit
  5. 30 Jul, 2017 2 commits
  6. 27 Jul, 2017 1 commit
    • Nicolas Fella's avatar
      Gave plasmoid some love · 66e5eefe
      Nicolas Fella authored
      Summary:
      Make the plasmoid content transparent
      Include battery info in header
      Only show remotekeyboard input if available
      Make header always centered
      
      before:
      {F3820966}
      
      after:
      {F3820965}
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: jeanv, albertvaka, apol, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D6943
      66e5eefe
  7. 26 Jul, 2017 1 commit
  8. 24 Jul, 2017 2 commits
  9. 23 Jul, 2017 2 commits
  10. 22 Jul, 2017 3 commits
  11. 21 Jul, 2017 1 commit
    • Jean Vincent's avatar
      Replace Q_FOREACH with C++11 range-for · c864267f
      Jean Vincent authored
      Summary:
      The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.
      
      I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).
      
      I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.
      
      (This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: albertvaka, apol, nicolasfella
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D6724
      c864267f
  12. 19 Jul, 2017 2 commits
  13. 14 Jul, 2017 3 commits
  14. 13 Jul, 2017 5 commits
  15. 12 Jul, 2017 2 commits
  16. 11 Jul, 2017 1 commit
  17. 07 Jul, 2017 1 commit
    • Aleix Pol Gonzalez's avatar
      Improve debug information · 29888cb7
      Aleix Pol Gonzalez authored
      If we're ignoring an ssl issue, at least show it.
      On connected show whether the socket is valid, otherwise we get remote
      devices disconnected without any message. (In this case HostNameMismatch)
      Also fixes a typo
      
      CCBUG: 381542
      29888cb7
  18. 30 Jun, 2017 1 commit
  19. 28 Jun, 2017 2 commits
  20. 21 Jun, 2017 1 commit
  21. 20 Jun, 2017 3 commits
  22. 19 Jun, 2017 1 commit
  23. 13 Jun, 2017 1 commit
  24. 12 Jun, 2017 1 commit