1. 29 Jul, 2020 2 commits
  2. 28 Jul, 2020 1 commit
  3. 08 Jul, 2020 1 commit
  4. 26 May, 2020 1 commit
    • Antonio Larrosa Jimenez's avatar
      Use ecm_qt_declare_logging_category to declare the logging categories · 1d361642
      Antonio Larrosa Jimenez authored
      This automatizes the generation of logging categories so a
      kdeconnect-kde.categories is generated and installed to
      /usr/share/qlogging-categories5/ so kdebugsettings can use it.
      
      Also, sets the default logging level to Warning. So now the logs
      of users won't be filled with debug messages but they can
      modify the configuration easily with kdebugsettings.
      1d361642
  5. 07 Apr, 2020 1 commit
  6. 21 Jul, 2019 1 commit
  7. 19 Jul, 2019 2 commits
    • Simon Redman's avatar
      [SMS App] Handle addresses for multitarget messages · edee0e0e
      Simon Redman authored
      ## Summary
      
      Upgrade the SMS App to handle multitarget addresses in the "addresses" field of a message and drop usage of the "address" field
      
      Also note that this has all the commits from https://invent.kde.org/kde/kdeconnect-kde/merge_requests/97, but I will rebase those away once that patch is landed
      
      Bonus: Image composition for multitarget conversations
      
      ## Test Plan
      - Apply Android-side patch https://invent.kde.org/kde/kdeconnect-android/merge_requests/80
      - Launch SMS App
      - Notice that you can see all the recipients of multitarget messages. (Replying still not supported, but might get implemented as part of fixing replying to single-target messages)
      edee0e0e
    • Simon Redman's avatar
      [SMS App] Basic plain-text MMS support · ee9547ed
      Simon Redman authored
      ## Summary
      
      Desktop companion to https://invent.kde.org/kde/kdeconnect-android/merge_requests/78
      
      Give desktop SMS app a basic understanding of the MMSes coming from Android:
      - Show a fake body if we get an attachment we can't display (for now, any attachment)
      - Display a fake contact header for multi-target messages since Android does not yet export multi-target address information
      - Disable attempting to reply to multi-target messages
      
      BUG: 398889
      
      ## Test Plan
      ### Before:
      MMS messages were silently dropped, meaning:
       - Group MMS conversations were not visible
       - Single-target conversations with the most-recent message an MMS were not visible
      
      ### After:
       - Install https://invent.kde.org/kde/kdeconnect-android/merge_requests/78
       - Multi-target conversations are displayed (kind of ugly, since they have no contact information
       - Single-target conversations which end with an MMS are displayed
       - Plain-text MMS is displayed nicely
       - MMS attachments don't show
         - MMS which are only an attachment with no body are displayed with a dummy body
      ee9547ed
  8. 12 Jun, 2019 1 commit
  9. 10 Jun, 2019 1 commit
  10. 29 Mar, 2019 1 commit
  11. 23 Mar, 2019 1 commit
  12. 21 Jan, 2019 1 commit
    • Simon Redman's avatar
      Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
      Simon Redman authored
      Summary:
      After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
      
      This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
      
      Test Plan:
      - Run daemon
      - Hopefully experience no crashes after many phone reconnects
      
      Reviewers: #kde_connect, apol, albertvaka
      
      Reviewed By: #kde_connect, apol, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16553
      74ba660c
  13. 13 Dec, 2018 2 commits
    • Simon Redman's avatar
      [SMS App] Allow scrolling up to load and display older messages · 2c35c1af
      Simon Redman authored
      Summary:
      Scroll up to show older messages
      
      Newly received messages will not force the view to the bottom unless the new message is being added "very close" to the visible area
      
      Test Plan:
      Message History:
       - Open conversation
       - Scroll/Drag up to load older messages
      
      New Message:
       - Open conversation
       - Scroll to bottom
       - Verify that a newly-received or newly-sent message is added to the GUI
       - Scroll up
       - Verify that sending/receiving a message does not disturb the view
       - Scroll back to verify that the new message was indeed added to the list
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T9556
      
      Differential Revision: https://phabricator.kde.org/D15979
      2c35c1af
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  14. 12 Dec, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Change ThreadID to long · 5cdfb9b0
      Simon Redman authored
      Summary: Change ThreadID to long
      
      Test Plan:
      Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.
      
      This patch corresponds to the Android-side revision D17517
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17516
      5cdfb9b0
  15. 16 Nov, 2018 1 commit
  16. 01 Nov, 2018 1 commit
  17. 07 Oct, 2018 1 commit
    • Simon Redman's avatar
      Correct braces and add contributors · 563dde98
      Simon Redman authored
      Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line
      
      Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15978
      563dde98
  18. 16 Sep, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] SMS plugin no longer creates desktop notifications -- Old... · 64062b3c
      Simon Redman authored
      [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin
      
      Summary:
      Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway
      
      Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_*
      
      Update TELEPHONY plugin packet description to point to SMS plugin
      
      Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field
      
      Please see Android-side patch here: D15544
      
      Test Plan:
      I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision:
       - New Android vs. New Desktop
         - Supported and works for me
       - New Android vs. Old Desktop
         - Supported and works for me
       - Old Android vs. New Desktop
         - Not supported - Download a new app from the Play store or F-Droid
       - Old Android vs. Old Desktop
         - If this is broken, it is not my fault :)
      
      In the supported use cases:
       - Test SMS reply
         - Receive SMS (or MMS!) message
         - Verify that the //notification// plugin forwards a replyable notification and that replying works
       - Test incoming call ringer mute
         - Enable ringer volume (not vibrate)
         - Receive phone call
         - Verify a desktop notification with a Mute button appears
         - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected)
      
      Reviewers: #kde_connect, albertvaka, nicolasfella
      
      Reviewed By: #kde_connect, albertvaka, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15543
      64062b3c
  19. 10 Sep, 2018 1 commit
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored
      Summary:
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: sredman
      
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13594
      bcc9fb06