1. 29 Jul, 2020 2 commits
  2. 08 Jul, 2020 1 commit
  3. 07 Apr, 2020 1 commit
  4. 22 Dec, 2019 1 commit
  5. 21 Jul, 2019 1 commit
  6. 20 Jul, 2019 1 commit
  7. 29 Mar, 2019 1 commit
  8. 23 Mar, 2019 1 commit
  9. 21 Jan, 2019 1 commit
    • Simon Redman's avatar
      Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
      Simon Redman authored
      Summary:
      After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
      
      This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
      
      Test Plan:
      - Run daemon
      - Hopefully experience no crashes after many phone reconnects
      
      Reviewers: #kde_connect, apol, albertvaka
      
      Reviewed By: #kde_connect, apol, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16553
      74ba660c
  10. 13 Dec, 2018 1 commit
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  11. 16 Nov, 2018 1 commit
  12. 07 Oct, 2018 1 commit
    • Simon Redman's avatar
      Correct braces and add contributors · 563dde98
      Simon Redman authored
      Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line
      
      Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15978
      563dde98
  13. 16 Sep, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] SMS plugin no longer creates desktop notifications -- Old... · 64062b3c
      Simon Redman authored
      [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin
      
      Summary:
      Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway
      
      Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_*
      
      Update TELEPHONY plugin packet description to point to SMS plugin
      
      Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field
      
      Please see Android-side patch here: D15544
      
      Test Plan:
      I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision:
       - New Android vs. New Desktop
         - Supported and works for me
       - New Android vs. Old Desktop
         - Supported and works for me
       - Old Android vs. New Desktop
         - Not supported - Download a new app from the Play store or F-Droid
       - Old Android vs. Old Desktop
         - If this is broken, it is not my fault :)
      
      In the supported use cases:
       - Test SMS reply
         - Receive SMS (or MMS!) message
         - Verify that the //notification// plugin forwards a replyable notification and that replying works
       - Test incoming call ringer mute
         - Enable ringer volume (not vibrate)
         - Receive phone call
         - Verify a desktop notification with a Mute button appears
         - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected)
      
      Reviewers: #kde_connect, albertvaka, nicolasfella
      
      Reviewed By: #kde_connect, albertvaka, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D15543
      64062b3c
  14. 10 Sep, 2018 1 commit
    • Simon Redman's avatar
      Split SMS and Telephony plugin on desktop · bcc9fb06
      Simon Redman authored and Nicolas Fella's avatar Nicolas Fella committed
      Summary:
      Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
      This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
      
      Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: sredman
      
      Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D13594
      bcc9fb06
  15. 09 Jun, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      (WIP) Upgrade Telephony plugin to read SMS history (KDE side) · 31e93ef7
      Aleix Pol Gonzalez authored and Simon Redman's avatar Simon Redman committed
      Summary:
      For real usecases of SMS support, we will almost always need access to the message history in some way
      
      Specifically resolve T8338
      
      Incidentally resolve T6651 since Telephony shall no longer create a notification
      
      Test Plan:
      Setup:
      - Build corresponding Android-side diff (D11698)
      - Build this diff
      
      Step 1: Does anything at all work?
      - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
      - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
      - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
      
      Step 2: DBus
      - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
      - Poke activeConversations and verify an empty array is returned
      - Poke requestAllConversationThreads
      - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
      - Use a conversationId to call getFirstFromConversation
        - Verify that the returned Message object is one which you recognize
        - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
      
      Step 3: SMS App
      - Use ccmake (or similar) to set SMSAPP_ENABLE to ON
      - Build the project
      - Run ./bin/kdeconnect-sms
      - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
        - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
      
      Reviewers: #kde_connect, nicolasfella, apol
      
      Reviewed By: #kde_connect, nicolasfella, apol
      
      Subscribers: andyholmes, apol, nicolasfella, #kde_connect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8338, T6651
      
      Differential Revision: https://phabricator.kde.org/D11854
      31e93ef7
  16. 05 Mar, 2018 1 commit
  17. 03 Sep, 2017 1 commit
    • Jean Vincent's avatar
      Make member variable names, & placement and * placement more coherent · 72535ecf
      Jean Vincent authored and Albert Vaca Cintora's avatar Albert Vaca Cintora committed
      Summary:
      Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
      Place all references and pointers on the side of the type since it is the majority.
      
      Basically:
       - mFoo -> m_foo
       - foo -> m_foo (if it is a member variable)
       - Type &ref -> Type& ref
       - Type *ptr -> Type* ptr
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, nicolasfella, albertvaka
      
      Subscribers: albertvaka, #kde_connect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D7312
      72535ecf
  18. 10 Jan, 2017 1 commit
    • Aleix Pol Gonzalez's avatar
      Reduce API exposed through dbus · 3734d6ce
      Aleix Pol Gonzalez authored
      Summary:
      Don't use QDBusConnection::ExportAllContents
      No need to make connect and receivedPackage public slots (they're are the
      parent's already)
      
      Fixes T4975
      
      Test Plan: Rough manual test
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Maniphest Tasks: T4975
      
      Differential Revision: https://phabricator.kde.org/D3871
      3734d6ce
  19. 26 Nov, 2016 1 commit
  20. 04 Nov, 2016 1 commit
  21. 22 Jun, 2016 1 commit
    • Albert Vaca Cintora's avatar
      Merge telephonyplugin and telepathy plugin · 9939b58d
      Albert Vaca Cintora authored
      We now use the telepathy interface when it's available, and fall back to
      our custom dialog when it's not. This also makes the kdeconnect telepathy
      connection manager be completely decoupled from the kdeconnect code.
      
      CCMAIL: david@davidedmundson.co.uk
      9939b58d
  22. 20 Jun, 2016 1 commit
  23. 18 Jun, 2016 3 commits
  24. 02 Jun, 2016 1 commit
  25. 31 May, 2016 1 commit
  26. 10 Sep, 2015 1 commit
    • David Edmundson's avatar
      Telepathy integration · e4cbf225
      David Edmundson authored
      This sends recieved text messages to any Telepathy client and allows the
      user to respond from there.
      This should work with both our clients and Empathy.
      
      An account on telepathy is created on activation.
      
      As Telepathy clients expect backends to be always running, this is
      started by the daemon to
      suppress client errors. The plugin system then talks to the same CM via
      use of a singleton accessor.
      
      Based on work by Alexandr Akulich then tidied up and rebased.
      e4cbf225
  27. 08 Sep, 2015 2 commits
  28. 14 Mar, 2015 1 commit
  29. 06 Jan, 2015 1 commit
  30. 21 Sep, 2014 1 commit
  31. 14 Jun, 2014 2 commits
  32. 29 Oct, 2013 1 commit
    • Aleix Pol Gonzalez's avatar
      Improved package dispatch to the different plugins · 5e151d18
      Aleix Pol Gonzalez authored and Albert Vaca Cintora's avatar Albert Vaca Cintora committed
      Before this patch, all plugins had to discard received packages that were
      not for themselves. This could be a security problem (a plugin could sniff
      other plugin's packages) and also adds some complexity and processing.
      
      This patch makes the device instance aware of what services are required
      by the different plugins and when a package is received the corresponding
      plugins will get the package.
      
      These services will be listed on the plugin's desktop file, so the user
      can decide whether to enable a plugin.
      
      Note that this only works for receiving, not sending.
      
      REVIEW: 113210
      5e151d18
  33. 02 Sep, 2013 1 commit
  34. 22 Aug, 2013 1 commit
  35. 15 Aug, 2013 1 commit