Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

  1. 10 Jun, 2019 1 commit
  2. 05 Jun, 2019 1 commit
    • Simon Redman's avatar
      Fix LanLinkProviderTest on Windows · c7579eb1
      Simon Redman authored
      ## Summary
      LanLinkProviderTest fails on Windows. This patch fixes that.
      
      I believe the root cause is that we are using a shared UDP socket to listen for identity broadcasts both in the LanLinkProvider and in the test. Apparently this works on Linux, but on Windows the LanLinkProvider picks up its own identity packet and pairs with itself.
      
      This patch gives a parameter to LanLinkProvider to allow it to listen and broadcast on different ports, then uses that ability in the test to make the test pass on Windows.
      
      ## Test Plan
      
      ### Before:
      lanlinkprovider test fails, first because it can't bind its UDP listener socket, and then because Windows seems to handle shared sockets differently than Linux, so the UDP broadcasts were not reaching the test's listener.
      
      ### After:
      lanlinkprovider test seems to pass reliably both in my Windows VM and in the CI
      c7579eb1
  3. 03 Jun, 2019 2 commits
  4. 26 May, 2019 2 commits
  5. 08 May, 2019 1 commit
  6. 04 May, 2019 3 commits
  7. 02 May, 2019 1 commit
  8. 01 May, 2019 2 commits
  9. 30 Apr, 2019 1 commit
  10. 31 Mar, 2019 1 commit
  11. 23 Mar, 2019 1 commit
  12. 09 Mar, 2019 1 commit
  13. 28 Feb, 2019 2 commits
  14. 12 Feb, 2019 1 commit
  15. 03 Feb, 2019 3 commits
  16. 27 Jan, 2019 2 commits
  17. 26 Jan, 2019 3 commits
  18. 19 Jan, 2019 1 commit
    • Matthijs Tijink's avatar
      Add description of bluetooth multiplexing protocol · e77c1c87
      Matthijs Tijink authored
      Summary:
      As mentioned on telegram, there are some fundamental issues with bluetooth. The only approach I could get working was multiplexing: manually sending multiple streams of data over a single connection.
      
      This is the description of that multiplexing protocol. I have an implementation of this protocol, but I'd first like some feedback to see if this is what we're going to use before finishing up those patches.
      
      See the document itself for more details. I make the protocol forward-compatible, although I don't expect we will need ever that.
      
      Test Plan: None, this is just a description.
      
      Reviewers: #kde_connect, andyholmes, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17987
      e77c1c87
  19. 18 Jan, 2019 1 commit
    • Nicolas Fella's avatar
      Allow newer TLS versions · 1b20ecec
      Nicolas Fella authored
      Summary:
      Instead of mandating TLS V1.0 use 1.0 or later.
      BUG: 400338
      
      Test Plan: Phone connects
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: thomasp, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18217
      1b20ecec
  20. 06 Jan, 2019 1 commit
    • Erik Duisters's avatar
      Do not close m_socket in socketError() · 9f5cdf1a
      Erik Duisters authored
      Summary:
      When android closes the payload socket (cancel share) calling m_socket.close() results
      in a recursive call to onError eventually leading to a segmentation violation
      
      Test Plan:
      Install D16491, share a large file from desktop to android and cancel the share on Android through
       the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
       a disconnect in sendNextPacket)
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17628
      9f5cdf1a
  21. 31 Dec, 2018 1 commit
    • Matthijs Tijink's avatar
      Add handling for the identity packet to be split across two messages. · 97551d09
      Matthijs Tijink authored
      Summary: If the identity packet is split across two packets, then save it until we get a notification that more data is available for reading over the bluetooth link.
      
      Test Plan: Connect a phone and laptop over Bluetooth, and verify that both the phone and laptop are able to see each other, and that either side can start and successfully go through the pairing process.
      
      Reviewers: #kde_connect, mtijink
      
      Reviewed By: #kde_connect, mtijink
      
      Subscribers: mtijink, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17789
      97551d09
  22. 24 Dec, 2018 1 commit
  23. 11 Dec, 2018 1 commit
  24. 30 Nov, 2018 1 commit
    • Erik Duisters's avatar
      Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown · b6c15289
      Erik Duisters authored
      Summary:
      Combine multiple upload jobs for files into a single KCompositeJob so only 1 notification will be shown
      Includes changes introduced in D16279
      
      Test Plan:
      1. Share of multiple files is performed using 1 composite job
      
         Setup:
      	- Select multiple (big) files in dolphin and share with an Android device
         Result:
      	- The files will be transferred using 1 CompositeUploadJob and showing only 1 notification
      
      2. Share of file while another share is already running adds job to existing composite job
      
         Setup:
      	- Select multiple (big) files in dolphin and share with an Android device
      	- Share an additional file with the same Android device
         Result:
      	- The files are all transferred using 1 CompositeUploadJob and showing only 1 notification
      	- The notification is updated after adding the last file
      
      3. Other packets are transmitted as usual
      
         Setup:
              - Setup sharing desktop notification with device
      	- Share a big file with an Android device
      	- Generate a desktop notification (eg. sending or receiving an email)
      
         Result:
      	- Notification packet is send immediately
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, broulik, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17081
      b6c15289
  25. 26 Nov, 2018 1 commit
    • Erik Duisters's avatar
      Show progress when sending a file from desktop · 2c9fde48
      Erik Duisters authored
      Summary:
      Show progress when sending a file from the desktop
      
      BUG: 355044
      
      Test Plan:
      Complete transfer:
      -Right click on a big file in dolphin
      -Select Send to xx via KDE Connect
      -Open the Notifications widget and verify progress is shown correctly
      
      Stop transfer:
      -Right click on a big file in dolphin
      -Select Send to xx via KDE Connect
      -Open The Notifications widget and press the stop/kill button
      -Observe that the file upload is stopped
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: apol, broulik, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16279
      2c9fde48
  26. 19 Nov, 2018 1 commit
    • Erik Duisters's avatar
      QTcpServer already has a list of pending connections and emits newConnection... · fb099074
      Erik Duisters authored
      QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection
      
      Summary:
      No need to emit newConnection in Server::incomingConnection because QTcpServer will emit it after incomingConnection returns
      QTcpServer also already has a list of pending connections so use that
      
      Test Plan: Send a file from desktop to android and observe that newConnection is only called once
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17009
      fb099074
  27. 10 Nov, 2018 1 commit
  28. 07 Nov, 2018 1 commit
  29. 03 Nov, 2018 1 commit