Commit 198789e6 authored by Nicolas Fella's avatar Nicolas Fella

Fix file dialog usage in app and plasmoid

fileDialog.open() does *not* block, so we need to move the sending to onAccepted. Not sure why I thought this ever worked.

BUG: 423975
parent 6cbaaa1a
Pipeline #27644 passed with stage
in 14 minutes and 21 seconds
......@@ -105,13 +105,9 @@ Kirigami.ScrollablePage
device: root.currentDevice
},
PluginItem {
readonly property var shareIface: ShareDbusInterfaceFactory.create(root.currentDevice.id())
pluginName: "share"
name: i18nd("kdeconnect-app", "Share File")
onClick: () => {
fileDialog.open()
shareIface.shareUrl(fileDialog.fileUrl)
}
onClick: () => fileDialog.open()
device: root.currentDevice
},
PluginItem {
......@@ -169,7 +165,9 @@ Kirigami.ScrollablePage
FileDialog {
id: fileDialog
readonly property var shareIface: ShareDbusInterfaceFactory.create(root.currentDevice.id())
title: i18nd("kdeconnect-app", "Please choose a file")
folder: shortcuts.home
onAccepted: shareIface.shareUrl(fileDialog.fileUrl)
}
}
......@@ -105,18 +105,14 @@ PlasmaComponents.ListItem
title: i18n("Please choose a file")
folder: shortcuts.home
selectMultiple: true
onAccepted: fileDialog.fileUrls.forEach(url => share.plugin.shareUrl(url))
}
id: shareFile
icon: "document-share"
visible: share.available
text: i18n("Share file")
onClicked: {
fileDialog.open()
fileDialog.fileUrls.forEach(function (url) {
share.plugin.shareUrl(url)
})
}
onClicked: fileDialog.open()
}
//Find my phone
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment