Commit b3d78d6d authored by Nicolas Fella's avatar Nicolas Fella Committed by Simon Redman
Browse files

[notifications] Drop no icon hack

parent 1a9c2dbc
Pipeline #18250 failed with stage
in 4 minutes and 58 seconds
[Global]
IconName=kdeconnect
Name=KDE Connect
Name[ar]=كدي المتّصل
Name[ast]=KDE Connect
......
......@@ -135,7 +135,6 @@ void Notification::createKNotification(const NetworkPacket& np)
m_hasIcon = m_hasIcon && !m_payloadHash.isEmpty();
if (!m_hasIcon) {
applyNoIcon();
show();
} else {
m_iconPath = m_imagesDir.absoluteFilePath(m_payloadHash);
......@@ -169,7 +168,6 @@ void Notification::loadIcon(const NetworkPacket& np)
s_downloadsInProgress.remove(m_iconPath);
if (fileTransferJob->error()) {
qCDebug(KDECONNECT_PLUGIN_NOTIFICATION) << "Error in FileTransferJob: " << fileTransferJob->errorString();
applyNoIcon();
} else {
applyIcon();
}
......@@ -184,12 +182,6 @@ void Notification::applyIcon()
m_notification->setPixmap(icon);
}
void Notification::applyNoIcon()
{
//HACK The only way to display no icon at all is trying to load a non-existent icon
m_notification->setIconName(QStringLiteral("not_a_real_icon"));
}
void Notification::reply()
{
Q_EMIT replyRequested();
......
......@@ -96,7 +96,6 @@ private:
void parseNetworkPacket(const NetworkPacket& np);
void loadIcon(const NetworkPacket& np);
void applyIcon();
void applyNoIcon();
static QMap<QString, FileTransferJob*> s_downloadsInProgress;
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment