it's unreadable and also bound to break should the column indexes change

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

do not fail the build just because a new qt5/kf5 version deprecated
something...

This didn't make sense as the two are not connected.

Summary:
Compile without emit and foreach.
The private variables inside the model are prefixed with _, because
the userList variable shadowed class definition. This should clear things up.

And some better overloads and const qualifiers.

Test Plan: Compiles

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Differential Revision: https://phabricator.kde.org/D29118

Summary:
Fix compile warnings:
warning: zero as null pointer constant
warning: variable ‘result’ set but not used

Additionally some improved overloads and formatting which does not
deserve a sepearte patch ;-).

Test Plan: Compiles

Reviewers: #dolphin, ngraham, mlaurent

Reviewed By: #dolphin, ngraham

Differential Revision: https://phabricator.kde.org/D29105

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
After Samba is installed, very frequently it will not work correctly until the machine is
rebooted. One potential reason is when the installed package has made group membership
changes, which only take effect after a reboot.

This patch implements a reboot recommendation along with a button to reboot the machine.
Both are shown immediately after Samba has been installed.

Because some expert users may understand the technical details of what's going on, the
reboot is only recommended, not required. If the window is closed and then re-opened,
the normal Samba sharing configuration UI is displayed instead of the reboot prompt.

Added a new function rather than using a Lambda because it may be useful for additional
purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846)

FEATURE: 407845
FIXED-IN: 20.04.0

Test Plan:
http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size limit)

1. Remove Samba
2. Go to share a folder
3. Click "Install Samba"
4. After the installation has completed, click the "Restart" button and see that the machine reboots

5. Remove Samba again
2. Go to share a folder
3. Click "Install Samba"
4. Close the window and re-open it instead of rebooting as recommended
5. See that the Samba sharing config UI is all there

Reviewers: #vdg, #frameworks, #dolphin, apol, sitter

Reviewed By: sitter

Subscribers: anthonyfieroni, sitter, bruns

Differential Revision: https://phabricator.kde.org/D21466

Summary:
the max uid is now actually being used to cap the displayed uids (e.g.
I have a system user created beyond my MAX_UID of 60000 that were
erroneously shown because the detected maxuid was unused)

Test Plan: the excess user no longer shows up

Reviewers: ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D26964

Summary:
the pervious tech had shoddy coverage and was bound to eventually break
because of the rise of /etc/os-release to rule all the proprietary release
files that preceded it.

instead we now set sane default assumptions and attempt to load the actual
default for the specific system from /etc/login.defs (part of shadow source
and should be available on more or less all modern linux systems
https://github.com/shadow-maint/shadow).

Test Plan: max/min detection still works

Reviewers: ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D26963