1. 15 Mar, 2020 1 commit
    • Nate Graham's avatar
      Recommend rebooting after installing Samba · 8a104aa4
      Nate Graham authored
      Summary:
      After Samba is installed, very frequently it will not work correctly until the machine is
      rebooted. One potential reason is when the installed package has made group membership
      changes, which only take effect after a reboot.
      
      This patch implements a reboot recommendation along with a button to reboot the machine.
      Both are shown immediately after Samba has been installed.
      
      Because some expert users may understand the technical details of what's going on, the
      reboot is only recommended, not required. If the window is closed and then re-opened,
      the normal Samba sharing configuration UI is displayed instead of the reboot prompt.
      
      Added a new function rather than using a Lambda because it may be useful for additional
      purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846)
      
      FEATURE: 407845
      FIXED-IN: 20.04.0
      
      Test Plan:
      http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size limit)
      
      1. Remove Samba
      2. Go to share a folder
      3. Click "Install Samba"
      4. After the installation has completed, click the "Restart" button and see that the machine reboots
      
      5. Remove Samba again
      2. Go to share a folder
      3. Click "Install Samba"
      4. Close the window and re-open it instead of rebooting as recommended
      5. See that the Samba sharing config UI is all there
      
      Reviewers: #vdg, #frameworks, #dolphin, apol, sitter
      
      Reviewed By: sitter
      
      Subscribers: anthonyfieroni, sitter, bruns
      
      Differential Revision: https://phabricator.kde.org/D21466
      8a104aa4
  2. 19 Nov, 2019 1 commit
  3. 24 May, 2019 1 commit
  4. 22 May, 2019 2 commits
    • Nate Graham's avatar
      Add my copyright · 3b0ecf96
      Nate Graham authored
      3b0ecf96
    • Nate Graham's avatar
      Support installing multiple Samba packages · 0b2e5198
      Nate Graham authored
      Summary:
      Some distros (such as Manjaro) require multiple packages to be installed before a working
      Samba stack is present. This patch adjusts the CMake packaging and Samba auto-
      installation feature to support passing a comma-separated list of packages to support
      such distos.
      
      Test Plan:
      - Remove samba and try auto-installation again; it still works
      - Invoke CMake with multiple packages (e.g. `samba,rename`) and try auto-installation again; both packages and their dependencies get installed
      
      Reviewers: apol, #frameworks
      
      Reviewed By: apol
      
      Subscribers: bruns
      
      Differential Revision: https://phabricator.kde.org/D21327
      0b2e5198
  5. 17 May, 2019 1 commit
  6. 23 Sep, 2016 1 commit
  7. 14 Oct, 2015 2 commits
  8. 05 Oct, 2015 3 commits
  9. 28 Jul, 2015 1 commit
  10. 24 Jul, 2015 1 commit
  11. 19 Feb, 2011 2 commits
  12. 09 Jan, 2011 1 commit
  13. 27 Aug, 2007 1 commit
  14. 03 Feb, 2007 1 commit
  15. 29 May, 2006 1 commit
  16. 05 Oct, 2005 1 commit
  17. 29 Jul, 2005 1 commit
  18. 11 Jun, 2004 1 commit
  19. 01 Jun, 2004 1 commit
  20. 28 May, 2004 1 commit