Skip to content
  • Alexander Saoutkin's avatar
    Fix lifetime of slot in KIO-MTP · f4e0183a
    Alexander Saoutkin authored
    Summary:
    This slot was incorrectly made to last the lifetime of the slave. In fact, this
    slot should only be live for the lifetime of the event loop (one I/O operation).
    
    This can cause issues with the data being emitted for data from other IO
    operations. By making it live in the lifetime of the local event loop this
    scenario cannot occur as LIBMTP only allows one operation at a time.
    
    Test Plan:
    Via the use of KIOFuse (as this is where the bug was noticed).
    Before: Opening a file for the first time worked. Subsequent opens would fail
    due to garbage output After: Opening any number of files at any time works.
    
    Reviewers: akrutzler, dfaure, elvisangelaccio
    
    Subscribers: kde-frameworks-devel, kfm-devel, fvogt
    
    Tags: #dolphin, #frameworks
    
    Differential Revision: https://phabricator.kde.org/D28520
    f4e0183a