Commit 01e442c7 authored by David Edmundson's avatar David Edmundson

Correctly disable UDS_ACCESS being set

Summary:
718abcb6 tries to disable UDS_ACCESS
being set. See the long comment introduced.

It did this by setting the value to -1 which doesn't achieve that
result.

-1 is a perfectly valid value that gets send to the client.

Having it set breaks anyone calling udsEntry.numberValue(UDS_ACCESS,
aLegitimateDefault) getting their default. Something used by kio-fuse.

Test Plan:
Used kio-fuse
Opened a samba file in mplayer
It opened

Opened a text editor in kate (using regular kio)

Reviewers: sitter, feverfew

Reviewed By: sitter

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27810
parent 22e6647b
...@@ -118,8 +118,6 @@ int SMBSlave::browse_stat_path(const SMBUrl& _url, UDSEntry& udsentry) ...@@ -118,8 +118,6 @@ int SMBSlave::browse_stat_path(const SMBUrl& _url, UDSEntry& udsentry)
// dir is readonly as per the above microsoft support article. // dir is readonly as per the above microsoft support article.
// Also see: // Also see:
// https://docs.microsoft.com/en-us/windows/win32/shell/how-to-customize-folders-with-desktop-ini // https://docs.microsoft.com/en-us/windows/win32/shell/how-to-customize-folders-with-desktop-ini
udsentry.fastInsert(KIO::UDSEntry::UDS_ACCESS, -1);
udsentry.fastInsert(KIO::UDSEntry::UDS_FILE_TYPE, st.st_mode & S_IFMT); udsentry.fastInsert(KIO::UDSEntry::UDS_FILE_TYPE, st.st_mode & S_IFMT);
udsentry.fastInsert(KIO::UDSEntry::UDS_SIZE, st.st_size); udsentry.fastInsert(KIO::UDSEntry::UDS_SIZE, st.st_size);
udsentry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, st.st_mtime); udsentry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, st.st_mtime);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment