Commit 82528611 authored by Harald Sitter's avatar Harald Sitter 🏳🌈
Browse files

smb: do not double finish

Summary:
finish() must not be called twice yet previously the case branches
would call it but then there'd also be a global finished after the switch.
remove the cases' finished().

this code is, I think, actually not used anywhere so it matters little.

Test Plan: hoping for the best!

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D28014
parent 4107f48c
...@@ -116,8 +116,6 @@ void SMBSlave::special(const QByteArray &data) ...@@ -116,8 +116,6 @@ void SMBSlave::special(const QByteArray &data)
error(KIO::ERR_CANNOT_MOUNT, i18n("Mounting of share \"%1\" from host \"%2\" by user \"%3\" failed.\n%4", share, host, user, mybuf + '\n' + mystderr)); error(KIO::ERR_CANNOT_MOUNT, i18n("Mounting of share \"%1\" from host \"%2\" by user \"%3\" failed.\n%4", share, host, user, mybuf + '\n' + mystderr));
return; return;
} }
finished();
} break; } break;
case 2: case 2:
case 4: { case 4: {
...@@ -162,8 +160,6 @@ void SMBSlave::special(const QByteArray &data) ...@@ -162,8 +160,6 @@ void SMBSlave::special(const QByteArray &data)
return; return;
} }
} }
finished();
} break; } break;
default: default:
break; break;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment