Commit 92022286 authored by Ömer Fadıl Usta's avatar Ömer Fadıl Usta 😊
Browse files

Add missing include <thread>

Otherwise, gcc thinks this_thread is coming from std instead of thread
parent ec900f61
Pipeline #62324 passed with stage
in 4 minutes and 47 seconds
......@@ -12,6 +12,7 @@
#include <array>
#include <condition_variable>
#include <mutex>
#include <thread>
constexpr off_t c_minSegmentSize = 64 * 1024; // minimal size on stack
constexpr off_t c_maxSegmentSize = 4L * 1024 * 1024; // 4MiB is the largest request we make
  • Hi, I just came across kio-extras failing to build on the release/21.04 branch with latests openSUSE TW, and found it needed a fix like 71579088. Checking master afterwards, I found this commit. But now I am confused this commit added the include instead to transfer.h, while std::this_thread is only used in smb/autotests/transfertest.cpp ?

    Also am I confused right now what you mean exactly by

    Otherwise, gcc thinks this_thread is coming from std instead of thread

    "coming from std" is meant as in?

  • @kossebau to be honest I have committed this 4 weeks ago and I even don't remember what I have eaten yesterday :'(

    If you think I made a mistake about this commit , I will be glad if you can fix it. Thank you

  • Hm, I could not immediately tell what I ate yesterday either :P

    Okay, right now with no further information I would think we could move the include to the only file that needs it, will do then so tonight. Thanks for quick reply.

Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment