Commit c1a7f07d authored by Elvis Angelaccio's avatar Elvis Angelaccio

kfileaudiopreview: don't autoplay media files by default

Summary:
Not only it's annoying, but it's also a potential security risk (basically, a variant of [1]).

[1]: https://scarybeastsecurity.blogspot.com/2016/11/0day-poc-risky-design-decisions-in.html

Test Plan: No longer plays media files when hovering them in the file picker.

Reviewers: #plasma

Differential Revision: https://phabricator.kde.org/D7587
parent f2d14914
......@@ -80,7 +80,7 @@ KFileAudioPreview::KFileAudioPreview(QWidget *parent, const QVariantList &)
m_autoPlay = new QCheckBox(i18n("Play &automatically"), this);
KConfigGroup config(KSharedConfig::openConfig(), ConfigGroup);
m_autoPlay->setChecked(config.readEntry("Autoplay", true));
m_autoPlay->setChecked(config.readEntry("Autoplay", false));
connect(m_autoPlay, &QCheckBox::toggled, this, &KFileAudioPreview::toggleAuto);
QVBoxLayout *layout = new QVBoxLayout(this);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment