Commit c3d52ebe authored by Ahmad Samir's avatar Ahmad Samir
Browse files

kio_filenamesearch: fix crash due to KCoreDirLister changes

Error reporting was changed in KCoreDirlister, to match the original behaviour
we need to explicitly disable auto error handling.

This fixes a crash while searching in Dolphin, kio_filenamesearch intrenally
uses a dirlister, and a nested event loop, if there is an error while listing
some dir it tries to report it using a job ui delegate, but the parent job
could well be dead by that time, which causes a crash:
"QWidget: Cannot create a QWidget without QApplication"

Note that this crash only happens if KDE_FORK_SLAVES is _not_ set.

BUG: 438187
FIXED-IN: 21.08.3
(cherry picked from commit 5dff395e)
parent bcca3a48
......@@ -102,6 +102,7 @@ void FileNameSearchProtocol::searchDirectory(const QUrl &directory,
QScopedPointer<KCoreDirLister> dirLister(new KCoreDirLister);
dirLister->setDelayedMimeTypes(true);
dirLister->openUrl(directory);
dirLister->setAutoErrorHandlingEnabled(false);
QEventLoop eventLoop;
QObject::connect(dirLister.data(), static_cast<void(KCoreDirLister::*)()>(&KCoreDirLister::canceled),
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment