Verified Commit cab44f00 authored by Alexander Lohnau's avatar Alexander Lohnau 💬
Browse files

Remove configuration UI for JPEG thumbnailer

The options are very undiscoverable in dolphin and having
an option for this seems quite overkill to me. If people really want to
have this kind of configurability they should be using an image
viewer instead of looking at the thumbnails.

It also causes issues from a dependency kind of view.
Task: https://phabricator.kde.org/T14695
parent 1d2655f1
Pipeline #73053 passed with stage
in 3 minutes
......@@ -8,7 +8,6 @@
#include "jpegcreator.h"
#include "jpegcreatorsettings5.h"
#include <QCheckBox>
#include <QImage>
#include <QImageReader>
#include <klocalizedstring.h>
......@@ -42,20 +41,3 @@ bool JpegCreator::create(const QString &path, int width, int height, QImage &ima
return imageReader.read(&image);
}
QWidget *JpegCreator::createConfigurationWidget()
{
QCheckBox *rotateCheckBox = new QCheckBox(i18nc("@option:check", "Rotate the image automatically"));
rotateCheckBox->setChecked(JpegCreatorSettings::rotate());
return rotateCheckBox;
}
void JpegCreator::writeConfiguration(const QWidget *configurationWidget)
{
const QCheckBox *rotateCheckBox = qobject_cast<const QCheckBox*>(configurationWidget);
if (rotateCheckBox) {
JpegCreatorSettings* settings = JpegCreatorSettings::self();
settings->setRotate(rotateCheckBox->isChecked());
settings->save();
}
}
......@@ -16,8 +16,6 @@ class JpegCreator : public ThumbCreator
public:
JpegCreator();
bool create(const QString &path, int, int, QImage &img) override;
QWidget *createConfigurationWidget() override;
void writeConfiguration(const QWidget *configurationWidget) override;
};
#endif
......@@ -75,5 +75,4 @@ X-KDE-ServiceTypes=ThumbCreator
MimeType=image/jpeg;
X-KDE-Library=jpegthumbnail
CacheThumbnail=true
Configurable=true
ThumbnailerVersion=2
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment