GitLab

"flags & SSH_FILEXFER_ATTR_CREATETIME" check was missing in listDir

CCBUG: 375305

In libmtp 1.1.19, an empty string is returned instead of NULL for devices without a deviceName, which breaks accessing those devices with kio-mtp

it should annotate this source, not the source within the source

previously this behaved wildly inconsistently with the other copy
functions and other workers. copying on the same protocol doesn't really
change anything, if anything it  is even more expected to not disturb
the mtime, certainly when we were provided with a modify time, which all
this is contingent on anyway

applying the mtime was duplicated across multiple functions when indeed
it is largely the same code with only the actual setting being slightly
variable. use a template function with callback instead to share the
sharable bits.

also, since smbc_utime is used in two functions move that to its own
helper built on top to remove even the callback duplication

they can change behavior quite a bit

...to be more consistent with the rest of the code

previously we had a global timeout in smb_browse but that was eventually
removed to not break SMBC discovery, which is also used for listing
directories. this left WSD without any timeout system when no WSD hosts
are on the network because the internal timeout tracking would only
start after the first response.

instead implement the actually specified timeout mechanics of WSD.

- /Probe may only be Matched within MATCH_TIMEOUT (m_probeMatchTimer =
global timeout tracker now)
- /Resolve may only be Matched within MATCH_TIMEOUT (encapsulated inside
new WSDResolver)
- PBSD may only be answered within HTTP_TIMEOUT (couldn't find a
specified timeout so I'm guessing one would ordinarily use a default
http timeout, since we only do a single cheap query I'm using a more
opinionate timeout though)

MATCH_TIMEOUT is derived form the DPWS spec rather than the underlying
ws-discovery because it has more lenient timing and is generally a bit
more assertive with requirements.

BUG: 436574

Ahmad Samir authored Sep 10, 2021 and Ben Cooksley committed Sep 21, 2021

To get those definitions, copy them from kio/src/core/kioglobal_p.h

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- use auto on obvious new
- give the magic number a name so it's obvious why it is 6
- don't detatch

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Instead of recreating the whole menu every time the user right-clicks
a file, reuse the previously allocated menu

By including KIO/UDSEntry, which itself will include all the necessary system
headers, seems safer to me that way.

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- Create a UDSEntry for ioslave's own root '.'
- Previously KCoreDirLister was used, which internally uses KIO::ListJob,
  now we use a ListJob directly, less indirection, less potential overhead.

GIT_SILENT

Makes it easier to test changes by exporting 'QT_PLUGIN_PATH=<builddir>/bin'

Swith to kcoreaddons_add_plugin CMake macro.

GIT_SILENT

This is already done by SlaveBase::listEntry().
Return readable titles and usable URLs for section listing.

To better conform to current branding.

The missing error() caused an assertion failure in
SlaveBasePrivate::verifyState("get()") - it is not allowed to
return from get() without calling error() or finished().

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Not sure whether this will ever be used, though - do any
current systems apart from Solaris have SGML man pages?

Konqueror with the WebEnginePart sees the KIO error and displays a
generic error, ignoring the formatted HTML explanation.  KHTML
puts up a deceptive blank error box.  Only WebKit ignores the error
and displays the HTML as intended.  Call finished() so that the HTML
will be displayed whatever viewing part is in use.

Partial revert of commit d5f2beb2, as noted in
konqueror!83

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The options are very undiscoverable in dolphin and having
an option for this seems quite overkill to me. If people really want to
have this kind of configurability they should be using an image
viewer instead of looking at the thumbnails.

It also causes issues from a dependency kind of view.
Task: https://phabricator.kde.org/T14695

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The moc process already rebuilds the plugin when the JSON file changes, consequently the additional parameter is not needed.

Task: https://phabricator.kde.org/T14649